[Media Router] Parse device description xml in utility process

chrome/utility/media_router/dial_device_description_parser_impl.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_
+#define CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_
+
+#include "base/macros.h"
+#include "chrome/common/media_router/dial_device_description_parser.mojom.h"
+
+namespace media_router {
+
+// Implementation of Mojo DialDeviceDescriptionParser. It accepts device
+// description parsing request from browser process, and handles it in utility
+// process. Class must be created and destroyed on utility thread.
+class DialDeviceDescriptionParserImpl
+    : public chrome::mojom::DialDeviceDescriptionParser {
+ public:
+  DialDeviceDescriptionParserImpl();
+  ~DialDeviceDescriptionParserImpl() override;
+
+  static void Create(chrome::mojom::DialDeviceDescriptionParserRequest request);
+
+ private:
+  FRIEND_TEST_ALL_PREFIXES(DialDeviceDescriptionParserImplTest, TestInvalidXml);
+  FRIEND_TEST_ALL_PREFIXES(DialDeviceDescriptionParserImplTest,
+                           TestScrubXmlForLogging);
+  FRIEND_TEST_ALL_PREFIXES(DialDeviceDescriptionParserImplTest, TestParse);
+  FRIEND_TEST_ALL_PREFIXES(DialDeviceDescriptionParserImplTest,
+                           TestParseWithSpecialCharacter);
+  FRIEND_TEST_ALL_PREFIXES(DialDeviceDescriptionParserImplTest,
+                           TestParseWithoutFriendlyNameModelName);
+  FRIEND_TEST_ALL_PREFIXES(DialDeviceDescriptionParserImplTest,
+                           TestParseWithoutFriendlyName);

[dcheng, 2017/03/22 09:53:02]

FWIW, it might be easier to just add a test fixture, add a helper to call Parse
on the test fixture, and just friend the one test fixture.

Otherwise, please #include "base/gtest_prod_util.h" for this macro.

[zhaobin, 2017/03/22 19:18:52]

Done.

+
+  // extensions::mojom::DialDeviceDescriptionParser:
+  void ParseDialDeviceDescription(
+      const std::string& device_description_xml_data,
+      const ParseDialDeviceDescriptionCallback& callback) override;
+
+  // Processes the result of getting device description. Returns true and
+  // populates corresponding fields in |dial_device_description_| if processing
+  // succeeds; otherwise returns false.
+  // |xml|: The device description xml text.
+  // |out|: Parsed device description object.
+  bool Parse(const std::string& xml, media_router::DialDeviceDescription* out);
+
+  base::ThreadChecker thread_checker_;
+
+  DISALLOW_COPY_AND_ASSIGN(DialDeviceDescriptionParserImpl);
+};
+
+}  // namespace media_router
+
+#endif  // CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_