Flags change for this week's merge. These flags were introduced this

Flags change for this week's merge.  These flags were introduced this

R=rch@chromium.org
BUG=

[Ryan Hamilton, 2017-03-10 15:16:23]

https://codereview.chromium.org/2745643003/diff/1/net/quic/core/quic_flags_li...
File net/quic/core/quic_flags_list.h (left):

https://codereview.chromium.org/2745643003/diff/1/net/quic/core/quic_flags_li...
net/quic/core/quic_flags_list.h:173: QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_remove_multipath_bit, true)
It's surprising that these were true and are now false. Were they rolled back
internally, or were they explicitly set to true early in Chrome?

[jokulik, 2017-03-10 16:54:39]

On 2017/03/10 15:16:23, Ryan Hamilton wrote:
>
https://codereview.chromium.org/2745643003/diff/1/net/quic/core/quic_flags_li...
> File net/quic/core/quic_flags_list.h (left):
> 
>
https://codereview.chromium.org/2745643003/diff/1/net/quic/core/quic_flags_li...
> net/quic/core/quic_flags_list.h:173: QUIC_FLAG(bool,
> FLAGS_quic_reloadable_flag_quic_remove_multipath_bit, true)
> It's surprising that these were true and are now false. Were they rolled back
> internally, or were they explicitly set to true early in Chrome?

They were marked as "Flipped" in google3, which I thought meant I should set
them to true.  Then your script ran and marked them back as false.

[jokulik, 2017-03-10 17:30:35]

On 2017/03/10 16:54:39, jokulik wrote:
> On 2017/03/10 15:16:23, Ryan Hamilton wrote:
> >
>
https://codereview.chromium.org/2745643003/diff/1/net/quic/core/quic_flags_li...
> > File net/quic/core/quic_flags_list.h (left):
> > 
> >
>
https://codereview.chromium.org/2745643003/diff/1/net/quic/core/quic_flags_li...
> > net/quic/core/quic_flags_list.h:173: QUIC_FLAG(bool,
> > FLAGS_quic_reloadable_flag_quic_remove_multipath_bit, true)
> > It's surprising that these were true and are now false. Were they rolled
back
> > internally, or were they explicitly set to true early in Chrome?
> 
> They were marked as "Flipped" in google3, which I thought meant I should set
> them to true.  Then your script ran and marked them back as false.

So, to be clear, this is not really a change so much as a correction of an
earlier CL as part of this merge, where I marked two new flags as true when they
should have been false.

(I can see how that was totally unclear).

[Ryan Hamilton, 2017-03-10 18:12:10]

On 2017/03/10 17:30:35, jokulik wrote:
> On 2017/03/10 16:54:39, jokulik wrote:
> > On 2017/03/10 15:16:23, Ryan Hamilton wrote:
> > >
> >
>
https://codereview.chromium.org/2745643003/diff/1/net/quic/core/quic_flags_li...
> > > File net/quic/core/quic_flags_list.h (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/2745643003/diff/1/net/quic/core/quic_flags_li...
> > > net/quic/core/quic_flags_list.h:173: QUIC_FLAG(bool,
> > > FLAGS_quic_reloadable_flag_quic_remove_multipath_bit, true)
> > > It's surprising that these were true and are now false. Were they rolled
> back
> > > internally, or were they explicitly set to true early in Chrome?
> > 
> > They were marked as "Flipped" in google3, which I thought meant I should set
> > them to true.  Then your script ran and marked them back as false.
> 
> So, to be clear, this is not really a change so much as a correction of an
> earlier CL as part of this merge, where I marked two new flags as true when
they
> should have been false.
> 
> (I can see how that was totally unclear).

*facepalm* Yes, you are right of course! Sorry for the confusion on my part.

LGTM