Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 274563003: Resubmit: Add real file for AdNetworks DB (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
Reviewers:
James Hawkins, felt
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, arv+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Resubmit: Add real file for AdNetworks DB This is a resubmit of https://codereview.chromium.org/268063004/. The previous version was reverted because it caused a memory leak. This was a problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which has been fixed. Details: Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory (which according to the class comment, "the ref counting does not matter" [1]), the ref-counting _does_ matter. The fix for this went in as part of a refactor in https://codereview.chromium.org/263953003/. [1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44 BUG=357204 TBR=jhawkins@chromium.org (previously approved) TBR=felt@chromium.org (very minor changes) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269494

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M chrome/browser/extensions/activity_log/hashed_ad_network_database.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/hashed_ad_network_database.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/hashed_ad_network_database_unittest.cc View 4 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/resources/ad_networks.dat View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-09 00:52:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/274563003/80001
6 years, 7 months ago (2014-05-09 00:57:29 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 04:33:14 UTC) #3
commit-bot: I haz the power
Change committed as 269494
6 years, 7 months ago (2014-05-10 02:46:34 UTC) #4
Alpha Left Google
6 years, 7 months ago (2014-05-10 03:18:48 UTC) #5
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/277133002/ by hclam@chromium.org.

The reason for reverting is: Linux Asan is failing with this patch:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

Powered by Google App Engine
This is Rietveld 408576698