Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/resources/md_bookmarks/app.js

Issue 2745593004: [MD Bookmarks] Add draggable sidebar. (Closed)
Patch Set: address comments, add window resize handler Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/app.js
diff --git a/chrome/browser/resources/md_bookmarks/app.js b/chrome/browser/resources/md_bookmarks/app.js
index 23bb4984359987ce975042b8e94972673d61d652..6ed10bed12a00e1a1b48a3fd4f53ca5dc811fdec 100644
--- a/chrome/browser/resources/md_bookmarks/app.js
+++ b/chrome/browser/resources/md_bookmarks/app.js
@@ -9,6 +9,14 @@ Polymer({
bookmarks.StoreClient,
],
+ properties: {
+ /** @private */
+ sidebarWidth_: String,
+ },
+
+ /** @private{?function(!Event)} */
+ boundUpdateSidebarWidth_: null,
+
/** @override */
attached: function() {
chrome.bookmarks.getTree(function(results) {
@@ -19,6 +27,45 @@ Polymer({
bookmarks.Store.getInstance().init(initialState);
bookmarks.ApiListener.init();
+
+ }.bind(this));
+
+ this.boundUpdateSidebarWidth_ = this.updateSidebarWidth_.bind(this);
+
+ this.initializeSplitter_();
+ },
+
+ detached: function() {
+ window.removeEventListener('resize', this.boundUpdateSidebarWidth_);
+ },
+
+ /**
+ * Set up the splitter and set the initial width from localStorage.
+ * @private
+ */
+ initializeSplitter_: function() {
+ var splitter = this.$.splitter;
+ cr.ui.Splitter.decorate(splitter);
+ var splitterTarget = this.$.sidebar;
+
+ // The splitter persists the size of the left component in the local store.
+ if ('treeWidth' in window.localStorage) {
+ splitterTarget.style.width = window.localStorage['treeWidth'];
+ this.sidebarWidth_ = splitterTarget.getComputedStyleValue('width');
+ }
+
+ splitter.addEventListener('resize', function(e) {
+ window.localStorage['treeWidth'] = splitterTarget.style.width;
+ // TODO(calamity): This only fires when the resize is complete. This
+ // should be updated on every width change.
+ this.updateSidebarWidth_();
}.bind(this));
+
+ window.addEventListener('resize', this.boundUpdateSidebarWidth_);
+ },
+
+ /** @private */
+ updateSidebarWidth_: function() {
+ this.sidebarWidth_ = this.$.sidebar.getComputedStyleValue('width');
},
});

Powered by Google App Engine
This is Rietveld 408576698