Refactoring out the chromoting jni runtime class in favor of chromoting client runtime.

remoting/client/jni/chromoting_jni_instance.h

Index: remoting/client/jni/chromoting_jni_instance.h
diff --git a/remoting/client/jni/chromoting_jni_instance.h b/remoting/client/jni/chromoting_jni_instance.h
index 2e93981f94933ab010f7c7d9d9e73717f2c72344..4b59501ed6ffb9b36ce4a27934e9bbf152c4b3c0 100644
--- a/remoting/client/jni/chromoting_jni_instance.h
+++ b/remoting/client/jni/chromoting_jni_instance.h
@@ -32,7 +32,7 @@ class VideoRenderer;
 }  // namespace protocol
 
 class AudioPlayerAndroid;
-class ChromotingJniRuntime;
+class ChromotingClientRuntime;
 class JniClient;
 class JniPairingSecretFetcher;
 
@@ -47,8 +47,7 @@ class ChromotingJniInstance
   // Initiates a connection with the specified host. Call from the UI thread.
   // The instance does not take ownership of |jni_runtime|. To connect with an
   // unpaired host, pass in |pairing_id| and |pairing_secret| as empty strings.
-  ChromotingJniInstance(ChromotingJniRuntime* jni_runtime,
-                        base::WeakPtr<JniClient> jni_client,
+  ChromotingJniInstance(base::WeakPtr<JniClient> jni_client,

[nicholss, 2017/03/10 19:04:28]

So this is a change I am not 100% sure about, I chose to pull the runtime from
the static instance method. 

The downside is this means the runtime is not injectable for tests, but we do
not do this currently. The upside is it makes the client code easier to
understand. But perhaps a little magical. No more pushing around pointers to a
runtime object, just ask the singleton for it's runtime object. 

For tests we could build them without the runtime singleton and link in our own
test version if it comes to that.

[Yuwei, 2017/03/10 20:18:53]

Maybe the real runtime object is good enough for the tests. Mocking task runners
inside the runtime is nontrivial anyways... Also given that the runtime is just
a combination of global resources, you may just write some test-only setters for
test.

                         base::WeakPtr<JniPairingSecretFetcher> secret_fetcher,
                         std::unique_ptr<protocol::CursorShapeStub> cursor_stub,
                         std::unique_ptr<protocol::VideoRenderer> video_renderer,
@@ -142,8 +141,8 @@ class ChromotingJniInstance
   // Releases the resource in the right order.
   void ReleaseResources();
 
-  // Used to obtain task runner references and make calls to Java methods.
-  ChromotingJniRuntime* jni_runtime_;
+  // Used to obtain task runner references.
+  ChromotingClientRuntime* runtime_;
 
   base::WeakPtr<JniClient> jni_client_;