third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2745563004: Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2745563004: Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (Closed)

Patch Set: none Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp ('k') | third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h » ('j') | third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index 60a699f2a23db803f78673ff6f6dd353b1536d3b..a2c6de287b2910940ec08b3aca70e9526c64b7de 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -83,14 +83,11 @@ void PaintPropertyTreeBuilderTest::TearDown() {

source.moveBy((sourceLayoutObject)->paintOffset()); \

const auto& contentsProperties = \

*(ancestorLayoutObject)->paintProperties()->contentsProperties(); \

- LayoutRect actual = LayoutRect( \

- geometryMapper \

- ->sourceToDestinationVisualRect(FloatRect(source), \

- *(sourceLayoutObject) \

- ->paintProperties() \

- ->localBorderBoxProperties(), \

- contentsProperties) \

- .rect()); \

+ FloatRect actualFloatRect(source); \

+ geometryMapper->sourceToDestinationVisualRect( \

+ *(sourceLayoutObject)->paintProperties()->localBorderBoxProperties(), \

+ contentsProperties, actualFloatRect); \

+ LayoutRect actual(actualFloatRect); \

actual.moveBy(-(ancestorLayoutObject)->paintOffset()); \

EXPECT_EQ(expected, actual) \

<< "GeometryMapper: expected: " << expected.toString() \