Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/chromeos/arc/arc_session_manager.h

Issue 2745533005: Show notification during ARC managed provision (Closed)
Patch Set: Address feedback. New icon. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_session_manager.h
diff --git a/chrome/browser/chromeos/arc/arc_session_manager.h b/chrome/browser/chromeos/arc/arc_session_manager.h
index a9bf4f5e188b6e5bc026b322d814e1f020a89011..23ecca6bfd392c41a87d647281ee5c2d4b306007 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager.h
+++ b/chrome/browser/chromeos/arc/arc_session_manager.h
@@ -94,6 +94,10 @@ class ArcSessionManager : public ArcSessionRunner::Observer,
// is represented by "arc.enabled" preference, is updated.
virtual void OnArcPlayStoreEnabledChanged(bool enabled) {}
+ // Called to notify that checking of Android management status started
+ // during the opt-in flow.
+ virtual void OnArcOptInManagementCheckStarted() {}
+
// Called to notify that ARC has been initialized successfully.
virtual void OnArcInitialStart() {}
@@ -105,6 +109,11 @@ class ArcSessionManager : public ArcSessionRunner::Observer,
// browser_tests
virtual void OnArcDataRemoved() {}
+ // Called to notify that the error is requested by the session manager to be
+ // displayed in the support host. Note that this is not called in cases when
+ // the support app switches to an error page by itself.
hidehiko 2017/04/12 04:51:34 nit: could you add comment that "this is called ev
emaxx 2017/04/12 13:06:46 Done.
+ virtual void OnArcErrorShowRequested(ArcSupportHost::Error error) {}
+
protected:
virtual ~Observer() = default;
};
@@ -305,6 +314,11 @@ class ArcSessionManager : public ArcSessionRunner::Observer,
// is fixed.
void MaybeReenableArc();
+ // Requests the support host (if it exists) to show the error, and notifies
+ // the observers.
+ void ShowArcSupportHostError(ArcSupportHost::Error error,
+ bool should_show_send_feedback);
+
std::unique_ptr<ArcSessionRunner> arc_session_runner_;
// Unowned pointer. Keeps current profile.

Powered by Google App Engine
This is Rietveld 408576698