Cgroup-awareness for chromium

added cgroup total_memory_kb

BUG=620409

[Tom (Use chromium acct), 2017-03-09 05:56:28]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
mosajjal


added cgroup total_memory_kb

BUG=620409
==========

to

==========
Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
mosajjal


added cgroup total_memory_kb

BUG=620409
==========

[Tom (Use chromium acct), 2017-03-09 05:56:29]

thomasanderson@google.com changed reviewers:
+ thestig@chromium.org

[Tom (Use chromium acct), 2017-03-09 05:57:26]

thomasanderson@google.com changed reviewers:
+ thomasanderson@google.com

[Tom (Use chromium acct), 2017-03-09 05:57:26]

please run 'git cl format' for the next patch set

[Tom (Use chromium acct), 2017-03-09 05:59:17]

Also, were you able to actually compile this locally?  

For example, I'd expect this not to compile:
if !on_cgroup
    return 0

[mosajjal, 2017-03-09 06:04:47]

On 2017/03/09 05:59:17, Tom Anderson wrote:
> Also, were you able to actually compile this locally?  
> 
> For example, I'd expect this not to compile:
> if !on_cgroup
>     return 0

will fix formatting later. I haven't compiled this yet. As I said in the issue,
this is a basic draft. I wanted to know if I'm doing it right and the concept is
clear. I wanted to know if I'm reading the right files and comparing the right
results.

[mosajjal, 2017-03-09 07:34:02]

Fixed errors

[mosajjal, 2017-03-09 16:54:25]

The CQ bit was checked by alireza.root@gmail.com

[mosajjal, 2017-03-09 16:54:26]

The CQ bit was unchecked by alireza.root@gmail.com

[mosajjal, 2017-03-09 16:55:07]

The CQ bit was checked by alireza.root@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 16:55:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 16:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 16:55:44]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Tom (Use chromium acct), 2017-03-10 02:19:18]

I think this approach sounds good to me, for the most part.  But you'll have to
actually write the patch and test it so I can give more detailed comments :)

[Lei Zhang, 2017-03-10 02:26:32]

Please try to get a functional patch ready first before asking for a review.
Another aspect of readiness is code that actually compiles. For instance, what's
the point of writing IfOnCgroup() if there's no callers? If the compiler tried
to build this code, it will notice the unused function and warn. In Chromium,
warnings are considered errors, so the build would fail as is.

For formatting:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md

It's a lot to take in, so just try your best and we can point you in the right
direction from there.

[mosajjal, 2017-03-14 08:22:11]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
mosajjal


added cgroup total_memory_kb

BUG=620409
==========

to

==========
added cgroup total_memory_kb

BUG=620409
==========

[mosajjal, 2017-03-14 15:03:08]

On 2017/03/10 02:26:32, Lei Zhang (super slow) wrote:
> Please try to get a functional patch ready first before asking for a review.
> Another aspect of readiness is code that actually compiles. For instance,
what's
> the point of writing IfOnCgroup() if there's no callers? If the compiler tried
> to build this code, it will notice the unused function and warn. In Chromium,
> warnings are considered errors, so the build would fail as is.
> 
> For formatting:
> https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md
> 
> It's a lot to take in, so just try your best and we can point you in the right
> direction from there.

moved it to #2746793004

https://codereview.chromium.org/2746793004/

it compiles now (finally!)