Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: content/browser/resources/media/webrtc_internals.js

Issue 2745433004: Revert of webrtc-internals: dont remove tab (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/resources/media/tab_view.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var USER_MEDIA_TAB_ID = 'user-media-tab-id'; 5 var USER_MEDIA_TAB_ID = 'user-media-tab-id';
6 6
7 var tabView = null; 7 var tabView = null;
8 var ssrcInfoManager = null; 8 var ssrcInfoManager = null;
9 var peerConnectionUpdateTable = null; 9 var peerConnectionUpdateTable = null;
10 var statsTable = null; 10 var statsTable = null;
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 /** 174 /**
175 * Removes all information about a peer connection. 175 * Removes all information about a peer connection.
176 * 176 *
177 * @param {!Object<number>} data The object containing the pid and lid of a peer 177 * @param {!Object<number>} data The object containing the pid and lid of a peer
178 * connection. 178 * connection.
179 */ 179 */
180 function removePeerConnection(data) { 180 function removePeerConnection(data) {
181 var element = $(getPeerConnectionId(data)); 181 var element = $(getPeerConnectionId(data));
182 if (element) { 182 if (element) {
183 delete peerConnectionDataStore[element.id]; 183 delete peerConnectionDataStore[element.id];
184 // add a [x] button to close this tab instead of removing it immediately. 184 tabView.removeTab(element.id);
185 tabView.makeTabRemovable(element.id);
186 } 185 }
187 } 186 }
188 187
189 188
190 /** 189 /**
191 * Adds a peer connection. 190 * Adds a peer connection.
192 * 191 *
193 * @param {!Object} data The object containing the pid, lid, url, 192 * @param {!Object} data The object containing the pid, lid, url,
194 * rtcConfiguration, and constraints of a peer connection. 193 * rtcConfiguration, and constraints of a peer connection.
195 */ 194 */
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 function eventLogRecordingsFileSelectionCancelled() { 338 function eventLogRecordingsFileSelectionCancelled() {
340 dumpCreator.disableEventLogRecordings(); 339 dumpCreator.disableEventLogRecordings();
341 } 340 }
342 341
343 /** 342 /**
344 * Set 343 * Set
345 */ 344 */
346 function enableAudioDebugRecordings() { 345 function enableAudioDebugRecordings() {
347 dumpCreator.enableAudioDebugRecordings(); 346 dumpCreator.enableAudioDebugRecordings();
348 } 347 }
OLDNEW
« no previous file with comments | « content/browser/resources/media/tab_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698