Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: src/feedback-vector.cc

Issue 2745413006: Revert of Collect type profile for DevTools. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/feedback-vector.h ('k') | src/feedback-vector-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/feedback-vector.cc
diff --git a/src/feedback-vector.cc b/src/feedback-vector.cc
index ef62a634fd55c93b9547869505eec7b44e3def25..5d842763994c75d047839b9423b2d2be298b744d 100644
--- a/src/feedback-vector.cc
+++ b/src/feedback-vector.cc
@@ -149,8 +149,6 @@
return "kCreateClosure";
case FeedbackSlotKind::kLiteral:
return "LITERAL";
- case FeedbackSlotKind::kTypeProfile:
- return "TYPE_PROFILE";
case FeedbackSlotKind::kGeneral:
return "STUB";
case FeedbackSlotKind::kKindsNumber:
@@ -158,18 +156,6 @@
}
UNREACHABLE();
return "?";
-}
-
-bool FeedbackMetadata::HasTypeProfileSlot() {
- FeedbackMetadataIterator iter(this);
- while (iter.HasNext()) {
- iter.Next();
- FeedbackSlotKind kind = iter.kind();
- if (kind == FeedbackSlotKind::kTypeProfile) {
- return true;
- }
- }
- return false;
}
FeedbackSlotKind FeedbackVector::GetKind(FeedbackSlot slot) const {
@@ -233,7 +219,6 @@
case FeedbackSlotKind::kStoreKeyedStrict:
case FeedbackSlotKind::kStoreDataPropertyInLiteral:
case FeedbackSlotKind::kGeneral:
- case FeedbackSlotKind::kTypeProfile:
array->set(index, *uninitialized_sentinel, SKIP_WRITE_BARRIER);
break;
@@ -351,8 +336,7 @@
break;
}
case FeedbackSlotKind::kCreateClosure: {
- case FeedbackSlotKind::kTypeProfile:
- break;
+ break;
}
case FeedbackSlotKind::kGeneral: {
if (obj->IsHeapObject()) {
@@ -1039,49 +1023,5 @@
SetFeedbackExtra(*name);
}
-InlineCacheState CollectTypeProfileNexus::StateFromFeedback() const {
- Isolate* isolate = GetIsolate();
- Object* const feedback = GetFeedback();
-
- if (feedback == *FeedbackVector::UninitializedSentinel(isolate)) {
- return UNINITIALIZED;
- }
- return MONOMORPHIC;
-}
-
-void CollectTypeProfileNexus::Collect(Handle<Name> type) {
- Isolate* isolate = GetIsolate();
-
- Object* const feedback = GetFeedback();
- Handle<ArrayList> types;
-
- if (feedback == *FeedbackVector::UninitializedSentinel(isolate)) {
- types = ArrayList::New(isolate, 1);
- } else {
- types = Handle<ArrayList>(ArrayList::cast(feedback), isolate);
- }
- // TODO(franzih): Somehow sort this list. Either avoid duplicates
- // or use the common base type.
- SetFeedback(*ArrayList::Add(types, type));
-}
-
-void CollectTypeProfileNexus::Print() const {
- Isolate* isolate = GetIsolate();
-
- Object* const feedback = GetFeedback();
-
- if (feedback == *FeedbackVector::UninitializedSentinel(isolate)) {
- return;
- }
-
- Handle<ArrayList> list;
- list = Handle<ArrayList>(ArrayList::cast(feedback), isolate);
-
- for (int i = 0; i < list->Length(); i++) {
- String* name = String::cast(list->Get(i));
- PrintF("%s\n", name->ToCString().get());
- }
-}
-
} // namespace internal
} // namespace v8
« no previous file with comments | « src/feedback-vector.h ('k') | src/feedback-vector-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698