Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: src/runtime/runtime-object.cc

Issue 2745413006: Revert of Collect type profile for DevTools. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | test/inspector/type-profile/collect-type-profile.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 LookupIterator it = LookupIterator::PropertyOrElement( 684 LookupIterator it = LookupIterator::PropertyOrElement(
685 isolate, object, name, object, LookupIterator::OWN); 685 isolate, object, name, object, LookupIterator::OWN);
686 // Cannot fail since this should only be called when 686 // Cannot fail since this should only be called when
687 // creating an object literal. 687 // creating an object literal.
688 CHECK(JSObject::DefineOwnPropertyIgnoreAttributes(&it, value, attrs, 688 CHECK(JSObject::DefineOwnPropertyIgnoreAttributes(&it, value, attrs,
689 Object::DONT_THROW) 689 Object::DONT_THROW)
690 .IsJust()); 690 .IsJust());
691 return *object; 691 return *object;
692 } 692 }
693 693
694 RUNTIME_FUNCTION(Runtime_CollectTypeProfile) {
695 HandleScope scope(isolate);
696 DCHECK_EQ(4, args.length());
697 CONVERT_ARG_HANDLE_CHECKED(String, name, 0);
698 CONVERT_ARG_HANDLE_CHECKED(Object, value, 1);
699 CONVERT_ARG_HANDLE_CHECKED(FeedbackVector, vector, 2);
700 CONVERT_SMI_ARG_CHECKED(index, 3);
701
702 DCHECK(FLAG_type_profile);
703
704 Handle<Name> type = Object::TypeOf(isolate, value);
705 if (value->IsJSReceiver()) {
706 Handle<JSReceiver> object = Handle<JSReceiver>::cast(value);
707 type = JSReceiver::GetConstructorName(object);
708 }
709
710 CollectTypeProfileNexus nexus(vector, vector->ToSlot(index));
711 nexus.Collect(type);
712
713 PrintF("%s\n", name->ToCString().get());
714 nexus.Print();
715 PrintF("\n");
716
717 return *name;
718 }
719
720 // Return property without being observable by accessors or interceptors. 694 // Return property without being observable by accessors or interceptors.
721 RUNTIME_FUNCTION(Runtime_GetDataProperty) { 695 RUNTIME_FUNCTION(Runtime_GetDataProperty) {
722 HandleScope scope(isolate); 696 HandleScope scope(isolate);
723 DCHECK_EQ(2, args.length()); 697 DCHECK_EQ(2, args.length());
724 CONVERT_ARG_HANDLE_CHECKED(JSReceiver, object, 0); 698 CONVERT_ARG_HANDLE_CHECKED(JSReceiver, object, 0);
725 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1); 699 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1);
726 return *JSReceiver::GetDataProperty(object, name); 700 return *JSReceiver::GetDataProperty(object, name);
727 } 701 }
728 702
729 RUNTIME_FUNCTION(Runtime_GetConstructorName) { 703 RUNTIME_FUNCTION(Runtime_GetConstructorName) {
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
1021 if (!success) return isolate->heap()->exception(); 995 if (!success) return isolate->heap()->exception();
1022 MAYBE_RETURN( 996 MAYBE_RETURN(
1023 JSReceiver::CreateDataProperty(&it, value, Object::THROW_ON_ERROR), 997 JSReceiver::CreateDataProperty(&it, value, Object::THROW_ON_ERROR),
1024 isolate->heap()->exception()); 998 isolate->heap()->exception());
1025 return *value; 999 return *value;
1026 } 1000 }
1027 1001
1028 1002
1029 } // namespace internal 1003 } // namespace internal
1030 } // namespace v8 1004 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | test/inspector/type-profile/collect-type-profile.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698