Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: src/compiler/bytecode-graph-builder.cc

Issue 2745413006: Revert of Collect type profile for DevTools. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/feedback-vector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/bytecode-graph-builder.h" 5 #include "src/compiler/bytecode-graph-builder.h"
6 6
7 #include "src/ast/ast.h" 7 #include "src/ast/ast.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/compilation-info.h" 9 #include "src/compilation-info.h"
10 #include "src/compiler/access-builder.h" 10 #include "src/compiler/access-builder.h"
(...skipping 785 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 Node* value = environment()->LookupAccumulator(); 796 Node* value = environment()->LookupAccumulator();
797 int flags = bytecode_iterator().GetFlagOperand(2); 797 int flags = bytecode_iterator().GetFlagOperand(2);
798 VectorSlotPair feedback = 798 VectorSlotPair feedback =
799 CreateVectorSlotPair(bytecode_iterator().GetIndexOperand(3)); 799 CreateVectorSlotPair(bytecode_iterator().GetIndexOperand(3));
800 800
801 const Operator* op = javascript()->StoreDataPropertyInLiteral(feedback); 801 const Operator* op = javascript()->StoreDataPropertyInLiteral(feedback);
802 Node* node = NewNode(op, object, name, value, jsgraph()->Constant(flags)); 802 Node* node = NewNode(op, object, name, value, jsgraph()->Constant(flags));
803 environment()->RecordAfterState(node, Environment::kAttachFrameState); 803 environment()->RecordAfterState(node, Environment::kAttachFrameState);
804 } 804 }
805 805
806 void BytecodeGraphBuilder::VisitCollectTypeProfile() {
807 PrepareEagerCheckpoint();
808
809 Node* name =
810 environment()->LookupRegister(bytecode_iterator().GetRegisterOperand(0));
811 Node* value = environment()->LookupAccumulator();
812 Node* index = jsgraph()->Constant(bytecode_iterator().GetIndexOperand(1));
813
814 Node* vector = jsgraph()->Constant(feedback_vector());
815
816 const Operator* op = javascript()->CallRuntime(Runtime::kCollectTypeProfile);
817
818 Node* node = NewNode(op, name, value, vector, index);
819 environment()->RecordAfterState(node, Environment::kAttachFrameState);
820 }
821
822 void BytecodeGraphBuilder::VisitLdaContextSlot() { 806 void BytecodeGraphBuilder::VisitLdaContextSlot() {
823 const Operator* op = javascript()->LoadContext( 807 const Operator* op = javascript()->LoadContext(
824 bytecode_iterator().GetUnsignedImmediateOperand(2), 808 bytecode_iterator().GetUnsignedImmediateOperand(2),
825 bytecode_iterator().GetIndexOperand(1), false); 809 bytecode_iterator().GetIndexOperand(1), false);
826 Node* node = NewNode(op); 810 Node* node = NewNode(op);
827 Node* context = 811 Node* context =
828 environment()->LookupRegister(bytecode_iterator().GetRegisterOperand(0)); 812 environment()->LookupRegister(bytecode_iterator().GetRegisterOperand(0));
829 NodeProperties::ReplaceContextInput(node, context); 813 NodeProperties::ReplaceContextInput(node, context);
830 environment()->BindAccumulator(node); 814 environment()->BindAccumulator(node);
831 } 815 }
(...skipping 1760 matching lines...) Expand 10 before | Expand all | Expand 10 after
2592 it->source_position().ScriptOffset(), start_position_.InliningId())); 2576 it->source_position().ScriptOffset(), start_position_.InliningId()));
2593 it->Advance(); 2577 it->Advance();
2594 } else { 2578 } else {
2595 DCHECK_GT(it->code_offset(), offset); 2579 DCHECK_GT(it->code_offset(), offset);
2596 } 2580 }
2597 } 2581 }
2598 2582
2599 } // namespace compiler 2583 } // namespace compiler
2600 } // namespace internal 2584 } // namespace internal
2601 } // namespace v8 2585 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/feedback-vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698