chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc - Issue 2745323004: Introduce DATA_TYPE_DOM_STORAGE for DOM-Accessible storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

Issue 2745323004: Introduce DATA_TYPE_DOM_STORAGE for DOM-Accessible storage (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.h ('k') | chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

index a5522a56035073bc4a0a7490643b1182da257bfc..e03e934c76bb7dd548ded351dc30bd0ad2781ed2 100644

--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

@@ -343,6 +343,12 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(

DCHECK(((remove_mask & ~FILTERABLE_DATA_TYPES) == 0) ||

filter_builder.IsEmptyBlacklist());

+ // Embedder-defined DOM-accessible storage currently contains only

+ // one datatype, which is the durable storage permission.

+ if (remove_mask & BrowsingDataRemover::DATA_TYPE_EMBEDDER_DOM_STORAGE) {

+ remove_mask |= DATA_TYPE_DURABLE_PERMISSION;

+ }

if (origin_type_mask & BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB) {

content::RecordAction(

UserMetricsAction("ClearBrowsingData_MaskContainsUnprotectedWeb"));