Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm

Issue 2745323002: Adding std::ostream& operator<<(std::ostream& out, NSError* error) (Closed)
Patch Set: Moving operator<< to bluetooth_adapter_mac.mm Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/bluetooth_low_energy_device_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
index 0e860b5ed85a2eed0110ad67c37918864b1f204a..b15b0f5fcadaf62d1ec2116ba74141c329bc8f60 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
@@ -258,12 +258,11 @@ void BluetoothRemoteGattCharacteristicMac::DidUpdateValue(NSError* error) {
callbacks.swap(read_characteristic_value_callbacks_);
characteristic_value_read_or_write_in_progress_ = false;
if (error) {
- VLOG(1) << *this
- << ": Bluetooth error while reading for characteristic, domain: "
- << base::SysNSStringToUTF8(error.domain)
- << ", error code: " << error.code;
BluetoothGattService::GattErrorCode error_code =
BluetoothDeviceMac::GetGattErrorCodeFromNSError(error);
+ VLOG(1) << *this
+ << ": Bluetooth error while reading for characteristic, domain: "
+ << error << ", error code: " << error_code;
callbacks.second.Run(error_code);
return;
}
@@ -304,12 +303,11 @@ void BluetoothRemoteGattCharacteristicMac::DidWriteValue(NSError* error) {
callbacks.swap(write_characteristic_value_callbacks_);
characteristic_value_read_or_write_in_progress_ = false;
if (error) {
- VLOG(1) << *this
- << ": Bluetooth error while writing for characteristic, domain: "
- << base::SysNSStringToUTF8(error.domain)
- << ", error code: " << error.code;
BluetoothGattService::GattErrorCode error_code =
BluetoothDeviceMac::GetGattErrorCodeFromNSError(error);
+ VLOG(1) << *this
+ << ": Bluetooth error while writing for characteristic, error: "
+ << error << ", error code: " << error_code;
callbacks.second.Run(error_code);
return;
}
@@ -331,14 +329,12 @@ void BluetoothRemoteGattCharacteristicMac::DidUpdateNotificationState(
return;
}
if (error) {
- VLOG(1) << *this
- << ": Bluetooth error while modifying notification state for "
- "characteristic, domain: "
- << base::SysNSStringToUTF8(error.domain)
- << ", error code: " << error.code << ", localized description: "
- << base::SysNSStringToUTF8(error.localizedDescription);
BluetoothGattService::GattErrorCode error_code =
BluetoothDeviceMac::GetGattErrorCodeFromNSError(error);
+ VLOG(1) << *this
+ << ": Bluetooth error while modifying notification state for "
+ "characteristic, error: "
+ << error << ", error code: " << error_code;
reentrant_safe_callbacks.second.Run(error_code);
return;
}
« no previous file with comments | « device/bluetooth/bluetooth_low_energy_device_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698