Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/signin/browser_state_data_remover.mm

Issue 2745313004: Remove all ReadingList entries on managed account signout. (Closed)
Patch Set: feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/signin/browser_state_data_remover.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/signin/browser_state_data_remover.mm
diff --git a/ios/chrome/browser/signin/browser_state_data_remover.mm b/ios/chrome/browser/signin/browser_state_data_remover.mm
index 40f2a359a0771901f0a8c28c9fa6d9bc2ea4c792..8a4c63c78f579f64830818a5abc3e4340f0fc212 100644
--- a/ios/chrome/browser/signin/browser_state_data_remover.mm
+++ b/ios/chrome/browser/signin/browser_state_data_remover.mm
@@ -10,6 +10,7 @@
#include "components/signin/core/common/signin_pref_names.h"
#include "ios/chrome/browser/bookmarks/bookmarks_utils.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
+#include "ios/chrome/browser/reading_list/reading_list_remover_helper.h"
#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
#import "ios/chrome/browser/ui/commands/clear_browsing_data_command.h"
@@ -61,11 +62,24 @@ void BrowserStateDataRemover::RemoveBrowserStateData(ProceduralBlock callback) {
void BrowserStateDataRemover::NotifyWithDetails(
const IOSChromeBrowsingDataRemover::NotificationDetails& details) {
- // Remove bookmarks once all browsing data was removed.
+ // Remove bookmarks and Reading List entriesonce all browsing data was
+ // removed.
// Removal of browsing data waits for the bookmark model to be loaded, so
// there should be no issue calling the function here.
CHECK(RemoveAllUserBookmarksIOS(browser_state_))
<< "Failed to remove all user bookmarks.";
+ reading_list_remover_helper_ =
+ base::MakeUnique<reading_list::ReadingListRemoverHelper>(browser_state_);
+ reading_list_remover_helper_->RemoveAllUserReadingListItemsIOS(
+ base::Bind(&BrowserStateDataRemover::ReadingListCleaned,
+ base::Unretained(this), details));
+}
+
+void BrowserStateDataRemover::ReadingListCleaned(
+ const IOSChromeBrowsingDataRemover::NotificationDetails& details,
+ bool reading_list_cleaned) {
+ CHECK(reading_list_cleaned)
+ << "Failed to remove all user reading list items.";
if (details.removal_mask != kRemoveAllDataMask) {
NOTREACHED() << "Unexpected partial remove browsing data request "
« no previous file with comments | « ios/chrome/browser/signin/browser_state_data_remover.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698