Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2745313003: Move securityCheck out of V8WrapperInstantiationScope (Closed)
Patch Set: Stop unecessary includes of BindingSecurity.h Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
index a2fd8a7edacf81c48959ec5dc59d1bcceef032f8..c3f0dbf29bb49f2fdf6d262c3e887057e0812797 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
@@ -177,6 +177,10 @@ def interface_context(interface, interfaces):
is_array_buffer_or_view = interface.idl_type.is_array_buffer_or_view
is_typed_array_type = interface.idl_type.is_typed_array
+
+ if not (is_array_buffer_or_view or interface.is_partial):
+ includes.add('bindings/core/v8/BindingSecurity.h')
+
if is_array_buffer_or_view:
includes.update(('bindings/core/v8/V8ArrayBuffer.h',
'bindings/core/v8/V8SharedArrayBuffer.h'))
@@ -199,7 +203,6 @@ def interface_context(interface, interfaces):
# [CheckSecurity]
is_check_security = 'CheckSecurity' in extended_attributes
if is_check_security:
- includes.add('bindings/core/v8/BindingSecurity.h')
includes.add('core/frame/LocalDOMWindow.h')
# [DependentLifetime]

Powered by Google App Engine
This is Rietveld 408576698