Move securityCheck out of V8WrapperInstantiationScope

third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef V8DOMWrapper_h
 #define V8DOMWrapper_h
 
-#include "bindings/core/v8/BindingSecurity.h"
 #include "bindings/core/v8/DOMDataStore.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "core/CoreExport.h"
 #include "v8/include/v8.h"
 #include "wtf/Compiler.h"
 #include "wtf/text/AtomicString.h"
 
 namespace blink {
 
@@ skipping 73 matching lines @@
   SECURITY_CHECK(toScriptWrappable(wrapper) == impl);
   return wrapper;
 }
 
 class V8WrapperInstantiationScope {
   STACK_ALLOCATED();
 
  public:
   V8WrapperInstantiationScope(v8::Local<v8::Object> creationContext,
                               v8::Isolate* isolate,
-                              bool withSecurityCheck)
+                              const WrapperTypeInfo* type)
       : m_didEnterContext(false),
         m_context(isolate->GetCurrentContext()),
         m_tryCatch(isolate),
-        m_convertExceptions(false) {
+        m_type(type) {
     // creationContext should not be empty. Because if we have an
     // empty creationContext, we will end up creating
     // a new object in the context currently entered. This is wrong.
     RELEASE_ASSERT(!creationContext.IsEmpty());
     v8::Local<v8::Context> contextForWrapper =
         creationContext->CreationContext();
 
     // For performance, we enter the context only if the currently running
     // context is different from the context that we are about to enter.
     if (contextForWrapper == m_context)
       return;
-    if (withSecurityCheck) {
-      securityCheck(isolate, contextForWrapper);
-    } else {
-      m_convertExceptions = true;
-    }
+

[jochen (gone - plz use gerrit), 2017/03/15 19:56:13]

if you move this out, you'll want to make sure that we crash if we get here
without a security check callback defined - outside of blink's complicated
security model, we'll want to blanket disallow any cross context wrappers.

[adithyas, 2017/03/28 20:35:41]

Added an assertion.

     m_context = v8::Local<v8::Context>::New(isolate, contextForWrapper);
     m_didEnterContext = true;
     m_context->Enter();
   }
 
   ~V8WrapperInstantiationScope() {
     if (!m_didEnterContext) {
       m_tryCatch.ReThrow();
       return;
     }
     m_context->Exit();
-    // Rethrow any cross-context exceptions as security error.
-    if (m_tryCatch.HasCaught()) {
-      if (m_convertExceptions) {
-        m_tryCatch.Reset();
-        convertException();
-      }
+
+    v8::Isolate* isolate = m_context->GetIsolate();
+    v8::Local<v8::Value> caughtException = m_tryCatch.Exception();
+
+    m_tryCatch.Reset();
+    m_type->securityCheck(isolate, isolate->GetCurrentContext(), m_context,

[jbroman, 2017/03/15 19:58:41]

Do ArrayBuffer/ArrayBufferViews not go through V8WrapperInstantiationScope? It
looks like their |securityCheck| is null (which would segfault here).

[adithyas, 2017/03/28 20:35:41]

They do not (they don't call V8DOMWrapper::createWrapper to create wrappers).

+                          m_type->interfaceName, caughtException);
+
+    if (m_tryCatch.HasCaught())

[jochen (gone - plz use gerrit), 2017/03/15 19:56:13]

that won't work as you reset the trycatch above

[adithyas, 2017/03/28 20:35:41]

m_type->securityCheck can throw an exception, and this is to check if it did.
That call happens after the reset so I think this is ok.

       m_tryCatch.ReThrow();
-    }
   }
 
   v8::Local<v8::Context> context() const { return m_context; }
 
  private:
-  void securityCheck(v8::Isolate*, v8::Local<v8::Context> contextForWrapper);
-  void convertException();
-
   bool m_didEnterContext;
   v8::Local<v8::Context> m_context;
   v8::TryCatch m_tryCatch;
-  bool m_convertExceptions;
+  const WrapperTypeInfo* m_type;
 };
 
 }  // namespace blink
 
 #endif  // V8DOMWrapper_h