Move securityCheck out of V8WrapperInstantiationScope

third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 100 matching lines @@
                                        const Frame* target,
                                        ErrorReportOption);
   // This overload must be used only for detached windows.
   static bool shouldAllowAccessToDetachedWindow(
       const LocalDOMWindow* accessingWindow,
       const DOMWindow* target,
       ExceptionState&);
 
   static void failedAccessCheckFor(v8::Isolate*, const Frame* target);
 
+  // Returns true if the creation context can be entered from the current
+  // context. If the creation context cannot be entered, a security error is
+  // thrown and this method returns false.
+  static bool canEnterCreationContext(v8::Isolate*,

[Yuki, 2017/03/16 14:05:55]

Do you really want to expose this function in public?

[adithyas, 2017/03/28 20:35:41]

Nope, made it private.

+                                      v8::Local<v8::Context> currentContext,
+                                      v8::Local<v8::Context> creationContext,
+                                      const char* interfaceName);
+
+  static void securityCheckForClassesWithAccessCheckCallbacks(

[Yuki, 2017/03/16 14:05:55]

Does "Classes" here mean IDL interface?  If so, it's a bit confusing because
"class" sounds like a C++ class.

Also, rethrowExceptionAsSecurityError or something like that seems a better name
to me.

[adithyas, 2017/03/28 20:35:40]

Yes, I meant IDL interface here and not a C++ class. I think
rethrowExceptionAsSecurityError makes sense here, but not for the other
function, so I'll change the other one to
securityCheckForInterfacesWithoutAccessCheckCallbacks. 

+      v8::Isolate*,
+      v8::Local<v8::Context> currentContext,
+      v8::Local<v8::Context> creationContext,
+      const char* interfaceName,
+      v8::Local<v8::Value> crossContextException);
+
+  static void securityCheckForClassesWithoutAccessCheckCallbacks(
+      v8::Isolate*,
+      v8::Local<v8::Context> currentContext,
+      v8::Local<v8::Context> creationContext,
+      const char* interfaceName,
+      v8::Local<v8::Value> crossContextException);
+
  private:
   // Returns true if |accessingWindow| is allowed named access to |targetWindow|
   // because they're the same origin.  Note that named access should be allowed
   // even if they're cross origin as long as the browsing context name matches
   // the browsing context container's name.
   //
   // Unlike shouldAllowAccessTo, this function returns true even when
   // |accessingWindow| or |targetWindow| is a RemoteDOMWindow, but remember that
   // only limited operations are allowed on a RemoteDOMWindow.
   //
   // This function should be only used from V8Window::namedPropertyGetterCustom.
   friend class V8Window;
   static bool shouldAllowNamedAccessTo(const DOMWindow* accessingWindow,
                                        const DOMWindow* targetWindow);
 };
 
 }  // namespace blink
 
 #endif  // BindingSecurity_h