Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2745313003: Move securityCheck out of V8WrapperInstantiationScope (Closed)
Patch Set: Add TODO Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23 * THE POSSIBILITY OF SUCH DAMAGE. 23 * THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "bindings/core/v8/V8Initializer.h" 26 #include "bindings/core/v8/V8Initializer.h"
27 27
28 #include <memory> 28 #include <memory>
29 29
30 #include "bindings/core/v8/BindingSecurity.h"
30 #include "bindings/core/v8/DOMWrapperWorld.h" 31 #include "bindings/core/v8/DOMWrapperWorld.h"
31 #include "bindings/core/v8/RejectedPromises.h" 32 #include "bindings/core/v8/RejectedPromises.h"
32 #include "bindings/core/v8/RetainedDOMInfo.h" 33 #include "bindings/core/v8/RetainedDOMInfo.h"
33 #include "bindings/core/v8/ScriptController.h" 34 #include "bindings/core/v8/ScriptController.h"
34 #include "bindings/core/v8/ScriptValue.h" 35 #include "bindings/core/v8/ScriptValue.h"
35 #include "bindings/core/v8/ScriptWrappableVisitor.h" 36 #include "bindings/core/v8/ScriptWrappableVisitor.h"
36 #include "bindings/core/v8/SourceLocation.h" 37 #include "bindings/core/v8/SourceLocation.h"
37 #include "bindings/core/v8/UseCounterCallback.h" 38 #include "bindings/core/v8/UseCounterCallback.h"
38 #include "bindings/core/v8/V8Binding.h" 39 #include "bindings/core/v8/V8Binding.h"
39 #include "bindings/core/v8/V8DOMException.h" 40 #include "bindings/core/v8/V8DOMException.h"
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 } 495 }
495 496
496 DCHECK(ThreadState::MainThreadState()); 497 DCHECK(ThreadState::MainThreadState());
497 ThreadState::MainThreadState()->RegisterTraceDOMWrappers( 498 ThreadState::MainThreadState()->RegisterTraceDOMWrappers(
498 isolate, V8GCController::TraceDOMWrappers, 499 isolate, V8GCController::TraceDOMWrappers,
499 ScriptWrappableVisitor::InvalidateDeadObjectsInMarkingDeque, 500 ScriptWrappableVisitor::InvalidateDeadObjectsInMarkingDeque,
500 ScriptWrappableVisitor::PerformCleanup); 501 ScriptWrappableVisitor::PerformCleanup);
501 502
502 V8PerIsolateData::From(isolate)->SetThreadDebugger( 503 V8PerIsolateData::From(isolate)->SetThreadDebugger(
503 WTF::MakeUnique<MainThreadDebugger>(isolate)); 504 WTF::MakeUnique<MainThreadDebugger>(isolate));
505
506 BindingSecurity::InitWrapperCreationSecurityCheck();
504 } 507 }
505 508
506 static void ReportFatalErrorInWorker(const char* location, 509 static void ReportFatalErrorInWorker(const char* location,
507 const char* message) { 510 const char* message) {
508 // FIXME: We temporarily deal with V8 internal error situations such as 511 // FIXME: We temporarily deal with V8 internal error situations such as
509 // out-of-memory by crashing the worker. 512 // out-of-memory by crashing the worker.
510 CRASH(); 513 CRASH();
511 } 514 }
512 515
513 static void MessageHandlerInWorker(v8::Local<v8::Message> message, 516 static void MessageHandlerInWorker(v8::Local<v8::Message> message,
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 v8::Isolate::kMessageLog); 583 v8::Isolate::kMessageLog);
581 isolate->SetFatalErrorHandler(ReportFatalErrorInWorker); 584 isolate->SetFatalErrorHandler(ReportFatalErrorInWorker);
582 585
583 uint32_t here; 586 uint32_t here;
584 isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here) - 587 isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here) -
585 kWorkerMaxStackSize); 588 kWorkerMaxStackSize);
586 isolate->SetPromiseRejectCallback(PromiseRejectHandlerInWorker); 589 isolate->SetPromiseRejectCallback(PromiseRejectHandlerInWorker);
587 } 590 }
588 591
589 } // namespace blink 592 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698