Move securityCheck out of V8WrapperInstantiationScope

third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 26 matching lines @@
 
 namespace blink {
 
 class DOMWindow;
 class EventTarget;
 class ExceptionState;
 class Frame;
 class LocalDOMWindow;
 class Location;
 class Node;
+struct WrapperTypeInfo;
 
 class CORE_EXPORT BindingSecurity {
   STATIC_ONLY(BindingSecurity);
 
  public:
   enum class ErrorReportOption {
     DoNotReport,
     Report,
   };
 
@@ skipping 54 matching lines @@
                                        const Frame* target,
                                        ErrorReportOption);
   // This overload must be used only for detached windows.
   static bool shouldAllowAccessToDetachedWindow(
       const LocalDOMWindow* accessingWindow,
       const DOMWindow* target,
       ExceptionState&);
 
   static void failedAccessCheckFor(v8::Isolate*, const Frame* target);
 
+  // Returns true if the current context has access to creationContext, and
+  // throws a SecurityError if it doesn't have access.

[Yuki, 2017/04/06 08:26:15]

Probably it's good to write that these two functions (including
rethrowCrossContextException) are designed to be called only from
V8WrapperInstantiationScope.

[adithyas, 2017/04/06 19:04:20]

Done.

+  static bool shouldEnterCreationContext(v8::Isolate*,

[Yuki, 2017/04/06 08:26:15]

Can we follow the existing convention like the following?
  shouldAllowAccessToCreationContext(...)
because this function behaves mostly in the same way as other
shouldAllowAccessTo family.

[adithyas, 2017/04/06 19:04:20]

Done.

+                                         v8::Local<v8::Context> creationContext,
+                                         const WrapperTypeInfo*);
+
+  static void rethrowCrossContextException(
+      v8::Isolate*,
+      v8::Local<v8::Context> creationContext,
+      const WrapperTypeInfo*,
+      v8::Local<v8::Value> crossContextException);
+
+  static void initWrapperCreationSecurityCheck();
+
  private:
   // Returns true if |accessingWindow| is allowed named access to |targetWindow|
   // because they're the same origin.  Note that named access should be allowed
   // even if they're cross origin as long as the browsing context name matches
   // the browsing context container's name.
   //
   // Unlike shouldAllowAccessTo, this function returns true even when
   // |accessingWindow| or |targetWindow| is a RemoteDOMWindow, but remember that
   // only limited operations are allowed on a RemoteDOMWindow.
   //
   // This function should be only used from V8Window::namedPropertyGetterCustom.
   friend class V8Window;
   static bool shouldAllowNamedAccessTo(const DOMWindow* accessingWindow,
                                        const DOMWindow* targetWindow);
 };
 
 }  // namespace blink
 
 #endif  // BindingSecurity_h