Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Side by Side Diff: third_party/WebKit/Source/web/FullscreenController.h

Issue 2745313002: Avoid rotation anchor during transitional fullscreen states. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 // Called by content::RenderWidget (via WebWidget) to notify that we've 53 // Called by content::RenderWidget (via WebWidget) to notify that we've
54 // entered or exited fullscreen. This can be because we requested it, or it 54 // entered or exited fullscreen. This can be because we requested it, or it
55 // can be initiated by the browser directly. 55 // can be initiated by the browser directly.
56 void didEnterFullscreen(); 56 void didEnterFullscreen();
57 void didExitFullscreen(); 57 void didExitFullscreen();
58 58
59 // Called by Fullscreen (via ChromeClient) to notify that the fullscreen 59 // Called by Fullscreen (via ChromeClient) to notify that the fullscreen
60 // element has changed. 60 // element has changed.
61 void fullscreenElementChanged(Element*, Element*); 61 void fullscreenElementChanged(Element*, Element*);
62 62
63 bool isFullscreen() { return m_state == State::Fullscreen; } 63 bool isFullscreen() { return m_state != State::Initial; }
mlamouri (slow - plz ping) 2017/03/13 21:00:56 nit: should it be renamed "isFullscreenOrTransitio
64 64
65 void updateSize(); 65 void updateSize();
66 66
67 void didUpdateLayout(); 67 void didUpdateLayout();
68 68
69 protected: 69 protected:
70 explicit FullscreenController(WebViewImpl*); 70 explicit FullscreenController(WebViewImpl*);
71 71
72 private: 72 private:
73 void updatePageScaleConstraints(bool removeConstraints); 73 void updatePageScaleConstraints(bool removeConstraints);
(...skipping 18 matching lines...) Expand all
92 State m_state = State::Initial; 92 State m_state = State::Initial;
93 93
94 float m_initialPageScaleFactor = 0.0f; 94 float m_initialPageScaleFactor = 0.0f;
95 IntSize m_initialScrollOffset; 95 IntSize m_initialScrollOffset;
96 FloatPoint m_initialVisualViewportOffset; 96 FloatPoint m_initialVisualViewportOffset;
97 }; 97 };
98 98
99 } // namespace blink 99 } // namespace blink
100 100
101 #endif 101 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698