Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(139)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/mojo/BUILD.gn
Issue
2745293005
:
Moving mojo/validation test into LayoutTests (Closed)
Patch Set: remove extra old dependency
Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
BUILD.gn
mojo/edk/js/tests/run_js_unittests.cc
mojo/public/js/BUILD.gn
mojo/public/js/tests/validation_test_input_parser.js
mojo/public/js/tests/validation_unittest.js
third_party/WebKit/LayoutTests/mojo/BUILD.gn
third_party/WebKit/LayoutTests/mojo/gen_data_files_list.py
third_party/WebKit/LayoutTests/mojo/resources/validation_test_input_parser.js
third_party/WebKit/LayoutTests/mojo/validation.html
View unified diff
|
Download patch
« BUILD.gn
('K') |
« mojo/public/js/tests/validation_unittest.js
('k') |
third_party/WebKit/LayoutTests/mojo/gen_data_files_list.py »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
action("data_files") {
2
script = "gen_data_files_list.py"
3
outputs = [
4
"$target_gen_dir/data_files.txt",
5
]
6
args = rebase_path(outputs, root_build_dir)
7
}
OLD
NEW
« BUILD.gn
('K') |
« mojo/public/js/tests/validation_unittest.js
('k') |
third_party/WebKit/LayoutTests/mojo/gen_data_files_list.py »
('j') |
no next file with comments »
Issue 2745293005: Moving mojo/validation test into LayoutTests (Closed)
Created 3 years, 9 months ago by damargulis
Modified 3 years, 7 months ago
Reviewers: jbroman, alokp, Dirk Pranke, qyearsley, yzshen1
Base URL:
Comments: 30
This is Rietveld
408576698
Chromium Code Reviews
Issue 2745293005:
Moving mojo/validation test into LayoutTests (Closed)
