Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: components/translate/core/browser/translate_manager.cc

Issue 2745253005: Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) zh-TW users a… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/translate/core/browser/translate_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/translate_manager.cc
diff --git a/components/translate/core/browser/translate_manager.cc b/components/translate/core/browser/translate_manager.cc
index cd10a75ed8ac4e003ed4705582fa52063a534da8..ea1a1f9ecc19b521e93c012f8ca06658dc525964 100644
--- a/components/translate/core/browser/translate_manager.cc
+++ b/components/translate/core/browser/translate_manager.cc
@@ -224,10 +224,7 @@ void TranslateManager::InitiateTranslation(const std::string& page_lang) {
InitTranslateEvent(language_code, target_lang, *translate_prefs);
// Don't translate similar languages (ex: en-US to en).
- // Also do not offer to translate between Simplified and Traditional Chinese.
- if (language_code == target_lang ||
- (language_code == "zh-CN" && target_lang == "zh-TW") ||
- (language_code == "zh-TW" && target_lang == "zh-CN")) {
+ if (language_code == target_lang) {
TranslateBrowserMetrics::ReportInitiationStatus(
TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
return;
« no previous file with comments | « no previous file | components/translate/core/browser/translate_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698