Issue 2745163004: Optionally use Fasta with the new analysis driver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2745163004: Optionally use Fasta with the new analysis driver. (Closed)

Created:
3 years, 9 months ago by scheglov

Modified:
3 years, 9 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Optionally use Fasta with the new analysis driver. It's not ready to be enabled, but it is useful for me to enable it temporary, see what is broken, and continue patching the AST builder. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/63ef801665a0ab3c9a880a1713795e1bbf360512

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -14 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/file_state.dart	View		6 chunks	+75 lines, -12 lines	0 comments	Download
	M	pkg/analyzer/test/src/dart/analysis/driver_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as 63ef801665a0ab3c9a880a1713795e1bbf360512 (presubmit successful).

3 years, 9 months ago (2017-03-14 15:11:25 UTC) #4

Message was sent while issue was closed.

lgtm