Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2745133002: Create LookupMapAnalysis late. (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -117 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 6 chunks +17 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 13 chunks +125 lines, -109 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-13 13:40:43 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2745133002/diff/1/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart File pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart (right): https://codereview.chromium.org/2745133002/diff/1/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart#newcode196 pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:196: class LookupMapAnalysisImpl implements LookupMapAnalysis { maybe give it ...
3 years, 9 months ago (2017-03-14 05:47:01 UTC) #3
Johnni Winther
https://codereview.chromium.org/2745133002/diff/1/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart File pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart (right): https://codereview.chromium.org/2745133002/diff/1/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart#newcode196 pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:196: class LookupMapAnalysisImpl implements LookupMapAnalysis { On 2017/03/14 05:47:00, Siggi ...
3 years, 9 months ago (2017-03-15 13:38:00 UTC) #4
Johnni Winther
3 years, 9 months ago (2017-03-15 13:46:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0924b1726747aab51a3c47b701ab60b36fed36f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698