Printing: Keep track of WebContents lifetime for the native printing UI.

Printing: Keep track of WebContents lifetime for the native printing UI.

BUG=305368
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229566

[Vitaly Buka (NO REVIEWS), 2013-10-16 05:14:23]

lgtm

https://codereview.chromium.org/27451002/diff/1/chrome/browser/printing/print...
File chrome/browser/printing/printing_ui_web_contents_observer.h (right):

https://codereview.chromium.org/27451002/diff/1/chrome/browser/printing/print...
chrome/browser/printing/printing_ui_web_contents_observer.h:20: bool
GetParentView(gfx::NativeView* parent_view);
Why not just return gfx::NativeView*

[Lei Zhang, 2013-10-16 19:20:37]

On to patch set 2.

https://codereview.chromium.org/27451002/diff/1/chrome/browser/printing/print...
File chrome/browser/printing/printing_ui_web_contents_observer.h (right):

https://codereview.chromium.org/27451002/diff/1/chrome/browser/printing/print...
chrome/browser/printing/printing_ui_web_contents_observer.h:20: bool
GetParentView(gfx::NativeView* parent_view);
On 2013/10/16 05:14:24, Vitaly Buka wrote:
> Why not just return gfx::NativeView*

Hmm, gfx::NativeView is a foo* on most platforms, and a HWND on Windows, which I
believe is also really just a pointer. Changed to return a gfx::NativeView.

[Vitaly Buka (NO REVIEWS), 2013-10-16 19:23:47]

On 2013/10/16 19:20:37, Lei Zhang wrote:
> On to patch set 2.
> 
>
https://codereview.chromium.org/27451002/diff/1/chrome/browser/printing/print...
> File chrome/browser/printing/printing_ui_web_contents_observer.h (right):
> 
>
https://codereview.chromium.org/27451002/diff/1/chrome/browser/printing/print...
> chrome/browser/printing/printing_ui_web_contents_observer.h:20: bool
> GetParentView(gfx::NativeView* parent_view);
> On 2013/10/16 05:14:24, Vitaly Buka wrote:
> > Why not just return gfx::NativeView*
> 
> Hmm, gfx::NativeView is a foo* on most platforms, and a HWND on Windows, which
I
> believe is also really just a pointer. Changed to return a gfx::NativeView.

Thanks, that's what I tried to say, not a pointer to gfx::NativeView :-)

[commit-bot: I haz the power, 2013-10-17 18:36:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/27451002/13001

[commit-bot: I haz the power, 2013-10-17 22:07:26]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-17 23:23:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/27451002/45001

[commit-bot: I haz the power, 2013-10-18 01:43:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/27451002/45001

[commit-bot: I haz the power, 2013-10-18 21:37:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/27451002/45001

[commit-bot: I haz the power, 2013-10-19 15:38:14]

Change committed as 229566