Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2745063004: devtools[android]: Disable flaky DevtoolsProtocolTest.VirtualTimeTest. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/base64.h" 8 #include "base/base64.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 1296 matching lines...) Expand 10 before | Expand all | Expand 10 after
1307 std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue()); 1307 std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue());
1308 params->SetInteger("width", new_size.width()); 1308 params->SetInteger("width", new_size.width());
1309 params->SetInteger("height", new_size.height()); 1309 params->SetInteger("height", new_size.height());
1310 SendCommand("Emulation.setVisibleSize", std::move(params), true); 1310 SendCommand("Emulation.setVisibleSize", std::move(params), true);
1311 EXPECT_SIZE_EQ(new_size, (shell()->web_contents()) 1311 EXPECT_SIZE_EQ(new_size, (shell()->web_contents())
1312 ->GetRenderWidgetHostView() 1312 ->GetRenderWidgetHostView()
1313 ->GetViewBounds() 1313 ->GetViewBounds()
1314 .size()); 1314 .size());
1315 } 1315 }
1316 1316
1317 IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) { 1317 // TODO(701223): Enable this on android.
1318 #if defined(OS_ANDROID)
1319 #define MAYBE_VirtualTimeTest DISABLED_VirtualTimeTest
1320 #else
1321 #define MAYBE_VirtualTimeTest VirtualTimeTest
1322 #endif
1323 IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, MAYBE_VirtualTimeTest) {
1318 NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1); 1324 NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1);
1319 Attach(); 1325 Attach();
1320 1326
1321 std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue()); 1327 std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue());
1322 params->SetString("policy", "pause"); 1328 params->SetString("policy", "pause");
1323 SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true); 1329 SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
1324 1330
1325 params.reset(new base::DictionaryValue()); 1331 params.reset(new base::DictionaryValue());
1326 params->SetString("expression", 1332 params->SetString("expression",
1327 "setTimeout(function(){console.log('before')}, 1000);" 1333 "setTimeout(function(){console.log('before')}, 1000);"
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
1641 EXPECT_EQ("polyglottal", value); 1647 EXPECT_EQ("polyglottal", value);
1642 found++; 1648 found++;
1643 } else { 1649 } else {
1644 FAIL(); 1650 FAIL();
1645 } 1651 }
1646 } 1652 }
1647 EXPECT_EQ(2u, found); 1653 EXPECT_EQ(2u, found);
1648 } 1654 }
1649 1655
1650 } // namespace content 1656 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698