Change Fasta testing docs to use 32-bit when possible.

Change Fasta testing docs to use 32-bit when possible.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/0a1b7dffd3722a377fce968649ab954b6af75246

[Paul Berry, 2017-03-14 21:16:33]

paulberry@google.com changed reviewers:
+ ahe@google.com, vegorov@chromium.org

[ahe, 2017-03-15 14:58:51]

Thank you, Paul!

Since you're making changes to this file, I took the liberty to add a slightly
unrelated suggestion below.

https://codereview.chromium.org/2745053006/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/TESTING.md (right):

https://codereview.chromium.org/2745053006/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/TESTING.md:11: Most of the tests below use a 32-bit
build because the test runs significantly faster.
Should we include the command line for building? I use:

./tools/build.py --mode release --arch x64,ia32 runtime_kernel
dart_precompiled_runtime

We need to build remember to build before running -cdartk tests, as we otherwise
will be running the previously built version of Fasta.

[Paul Berry, 2017-03-15 17:24:09]

https://codereview.chromium.org/2745053006/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/TESTING.md (right):

https://codereview.chromium.org/2745053006/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/TESTING.md:11: Most of the tests below use a 32-bit
build because the test runs significantly faster.
On 2017/03/15 14:58:51, ahe wrote:
> Should we include the command line for building? I use:
> 
> ./tools/build.py --mode release --arch x64,ia32 runtime_kernel
> dart_precompiled_runtime
> 
> We need to build remember to build before running -cdartk tests, as we
otherwise
> will be running the previously built version of Fasta.

I actually think we're ok with what we've got.  For the test commands on lines
20, 29, and 32, it's not necessary to do a build.  For the test command on line
43, a build is necessary, but the command on line 43 takes care of it (note that
it says `./tools/build.py ... && ...`).

If you want to propose a CL that spells this out in more detail I'm open to it,
though.

[ahe, 2017-03-16 08:39:28]

lgtm

https://codereview.chromium.org/2745053006/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/TESTING.md (right):

https://codereview.chromium.org/2745053006/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/TESTING.md:11: Most of the tests below use a 32-bit
build because the test runs significantly faster.
On 2017/03/15 17:24:09, Paul Berry wrote:
> On 2017/03/15 14:58:51, ahe wrote:
> > Should we include the command line for building? I use:
> > 
> > ./tools/build.py --mode release --arch x64,ia32 runtime_kernel
> > dart_precompiled_runtime
> > 
> > We need to build remember to build before running -cdartk tests, as we
> otherwise
> > will be running the previously built version of Fasta.
> 
> I actually think we're ok with what we've got.  For the test commands on lines
> 20, 29, and 32, it's not necessary to do a build.  For the test command on
line
> 43, a build is necessary, but the command on line 43 takes care of it (note
that
> it says `./tools/build.py ... && ...`).
> 
> If you want to propose a CL that spells this out in more detail I'm open to
it,
> though.

Good point.

[Paul Berry, 2017-03-16 18:20:30]

Description was changed from

==========
Change Fasta testing docs to use 32-bit when possible.
==========

to

==========
Change Fasta testing docs to use 32-bit when possible.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0a1b7dffd3722a377fce968649ab954b6af75246
==========

[Paul Berry, 2017-03-16 18:20:31]

Committed patchset #1 (id:1) manually as
0a1b7dffd3722a377fce968649ab954b6af75246 (presubmit successful).