chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2744983002: [Page Load Metrics] Add page load metrics for omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2744983002: [Page Load Metrics] Add page load metrics for omnibox. (Closed)

Patch Set: Addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 2194083546eaf00460d57e8a4a8552e54f24076c..1eef544c32764859079ef18e1e4c487bda4ae1d2 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -21,6 +21,7 @@

#include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h"

@@ -121,6 +122,8 @@ void PageLoadMetricsEmbedder::RegisterObservers(

if (prerender_observer)

tracker->AddObserver(std::move(prerender_observer));

}

+ tracker->AddObserver(

+ base::MakeUnique<OmniboxSuggestionUsedMetricsObserver>(IsPrerendering()));

}

bool PageLoadMetricsEmbedder::IsPrerendering() const {