Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: third_party/WebKit/Source/devtools/front_end/Runtime.js

Issue 2744883003: DevTools: generalize setting UI for enum/select settings (Closed)
Patch Set: rebase and keep settings pure Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/Runtime.js
diff --git a/third_party/WebKit/Source/devtools/front_end/Runtime.js b/third_party/WebKit/Source/devtools/front_end/Runtime.js
index aa52da346f7c716c8a4ed26fc5cd9fe23f333b62..7d83daa5d99dd6591ea74a9d90e52d5ff48f3e1b 100644
--- a/third_party/WebKit/Source/devtools/front_end/Runtime.js
+++ b/third_party/WebKit/Source/devtools/front_end/Runtime.js
@@ -671,10 +671,20 @@ Runtime.ExtensionDescriptor = class {
* @type {!Array.<string>|undefined}
*/
this.contextTypes;
+
+ /**
+ * @type {!Array<!Runtime.ExtensionDescriptor.Option>|undefined}
+ */
+ this.options;
pfeldman 2017/05/10 20:58:42 You should not need to change runtime, pretty much
luoe 2017/05/11 21:39:43 Undone.
}
};
/**
+ * @typedef {{title: string, text: (string|undefined), value: *, raw: (boolean|undefined)}}
+ */
+Runtime.ExtensionDescriptor.Option;
+
+/**
* @unrestricted
*/
Runtime.Module = class {

Powered by Google App Engine
This is Rietveld 408576698