Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/Runtime.js

Issue 2744883003: DevTools: generalize setting UI for enum/select settings (Closed)
Patch Set: rebase and keep settings pure Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 664
665 /** 665 /**
666 * @type {string|undefined} 666 * @type {string|undefined}
667 */ 667 */
668 this.factoryName; 668 this.factoryName;
669 669
670 /** 670 /**
671 * @type {!Array.<string>|undefined} 671 * @type {!Array.<string>|undefined}
672 */ 672 */
673 this.contextTypes; 673 this.contextTypes;
674
675 /**
676 * @type {!Array<!Runtime.ExtensionDescriptor.Option>|undefined}
677 */
678 this.options;
pfeldman 2017/05/10 20:58:42 You should not need to change runtime, pretty much
luoe 2017/05/11 21:39:43 Undone.
674 } 679 }
675 }; 680 };
676 681
677 /** 682 /**
683 * @typedef {{title: string, text: (string|undefined), value: *, raw: (boolean|u ndefined)}}
684 */
685 Runtime.ExtensionDescriptor.Option;
686
687 /**
678 * @unrestricted 688 * @unrestricted
679 */ 689 */
680 Runtime.Module = class { 690 Runtime.Module = class {
681 /** 691 /**
682 * @param {!Runtime} manager 692 * @param {!Runtime} manager
683 * @param {!Runtime.ModuleDescriptor} descriptor 693 * @param {!Runtime.ModuleDescriptor} descriptor
684 */ 694 */
685 constructor(manager, descriptor) { 695 constructor(manager, descriptor) {
686 this._manager = manager; 696 this._manager = manager;
687 this._descriptor = descriptor; 697 this._descriptor = descriptor;
(...skipping 437 matching lines...) Expand 10 before | Expand all | Expand 10 after
1125 send(message) {}, 1135 send(message) {},
1126 1136
1127 /** 1137 /**
1128 * @return {!Promise<boolean>} 1138 * @return {!Promise<boolean>}
1129 */ 1139 */
1130 close() {} 1140 close() {}
1131 }; 1141 };
1132 1142
1133 /** @type {!Runtime} */ 1143 /** @type {!Runtime} */
1134 var runtime; 1144 var runtime;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698