DevTools: generalize setting UI for enum/select settings

third_party/WebKit/Source/devtools/front_end/common/Settings.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 57 matching lines @@
       case ('global'):
         storageType = Common.SettingStorageType.Global;
         break;
       default:
         storageType = Common.SettingStorageType.Global;
     }
     var setting = isRegex ? this.createRegExpSetting(settingName, defaultValue, undefined, storageType) :
                             this.createSetting(settingName, defaultValue, storageType);
     if (descriptor['title'])
       setting.setTitle(descriptor['title']);
+    if (descriptor['options'])
+      setting.setOptions(descriptor['options']);
     this._moduleSettings.set(settingName, setting);
   }
 
   /**
    * @param {string} settingName
    * @return {!Common.Setting}
    */
   moduleSetting(settingName) {
     var setting = this._moduleSettings.get(settingName);
     if (!setting)
@@ skipping 168 matching lines @@
    * @param {!Common.SettingsStorage} storage
    */
   constructor(settings, name, defaultValue, eventSupport, storage) {
     this._settings = settings;
     this._name = name;
     this._defaultValue = defaultValue;
     this._eventSupport = eventSupport;
     this._storage = storage;
     /** @type {string} */
     this._title = '';
+    /** @type {!Array<!Common.Setting.Option>|undefined} */
+    this._options;
   }
 
   /**
    * @param {function(!Common.Event)} listener
    * @param {!Object=} thisObject
    */
   addChangeListener(listener, thisObject) {
     this._eventSupport.addEventListener(this._name, listener, thisObject);
   }
 
@@ skipping 17 matching lines @@
   }
 
   /**
    * @param {string} title
    */
   setTitle(title) {
     this._title = title;
   }
 
   /**
+   * @return {!Array<!Common.Setting.Option>}
+   */
+  options() {

[lushnikov, 2017/03/11 00:46:00]

Let's not infect Common.Setting with fields which are used only for the sake of
rendering. Not every Common.Setting instance is shown in the settings screen.
It's a library-level instead of a UI-level concept.

[luoe, 2017/05/09 02:58:00]

Done.

+    return this._options || [];
+  }
+
+  /**
+   * @param {!Array<!Common.Setting.Option>} options
+   */
+  setOptions(options) {
+    this._options = options;
+  }
+
+  /**
    * @return {V}
    */
   get() {
     if (typeof this._value !== 'undefined')
       return this._value;
 
     this._value = this._defaultValue;
     if (this._storage.has(this._name)) {
       try {
         this._value = JSON.parse(this._storage.get(this._name));
@@ skipping 494 matching lines @@
 
 /**
  * @enum {symbol}
  */
 Common.SettingStorageType = {
   Global: Symbol('Global'),
   Local: Symbol('Local'),
   Session: Symbol('Session')
 };
 
+/** @typedef {!{title: string, value: *, raw: (boolean|undefined)}} */
+Common.Setting.Option;
+
 /**
  * @param {string} settingName
  * @return {!Common.Setting}
  */
 Common.moduleSetting = function(settingName) {
   return Common.settings.moduleSetting(settingName);
 };
 
 /**
  * @param {string} settingName
  * @return {!Common.Setting}
  */
 Common.settingForTest = function(settingName) {
   return Common.settings.settingForTest(settingName);
 };