[Payment Request] Generic edit form

ios/chrome/browser/payments/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//ios/web/js_compile.gni")
 
 js_compile_checked("injected_js") {
   sources = [
     "resources/payment_request_manager.js",
   ]
 }
 
 source_set("payments") {
   configs += [ "//build/config/compiler:enable_arc" ]
   sources = [
+    "credit_card_edit_coordinator.h",
+    "credit_card_edit_coordinator.mm",
+    "credit_card_edit_view_controller.h",

[lpromero, 2017/03/13 16:42:36]

For a follow-up CL: could you move the UI pieces to a payments_ui target and
integrate the view controller within Showcase?
https://chromium.googlesource.com/chromium/src/+/master/ios/showcase/README.md

[Moe, 2017/03/16 01:35:32]

Done.

+    "credit_card_edit_view_controller.mm",
     "js_payment_request_manager.h",
     "js_payment_request_manager.mm",
     "payment_items_display_coordinator.h",
     "payment_items_display_coordinator.mm",
     "payment_items_display_view_controller.h",
     "payment_items_display_view_controller.mm",
     "payment_items_display_view_controller_actions.h",
     "payment_method_selection_coordinator.h",
     "payment_method_selection_coordinator.mm",
     "payment_method_selection_view_controller.h",
     "payment_method_selection_view_controller.mm",
     "payment_method_selection_view_controller_actions.h",
     "payment_request.h",
     "payment_request.mm",
     "payment_request_coordinator.h",
     "payment_request_coordinator.mm",
+    "payment_request_edit_view_controller.h",
+    "payment_request_edit_view_controller.mm",
     "payment_request_error_coordinator.h",
     "payment_request_error_coordinator.mm",
     "payment_request_error_view_controller.h",
     "payment_request_error_view_controller.mm",
     "payment_request_error_view_controller_actions.h",
     "payment_request_manager.h",
     "payment_request_manager.mm",
     "payment_request_util.h",
     "payment_request_util.mm",
     "payment_request_view_controller.h",
@@ skipping 23 matching lines @@
     "//ios/chrome/browser/autofill",
     "//ios/chrome/browser/browser_state",
     "//ios/chrome/browser/payments/cells",
     "//ios/chrome/browser/ui",
     "//ios/chrome/browser/ui/autofill",
     "//ios/chrome/browser/ui/autofill/cells",
     "//ios/chrome/browser/ui/collection_view",
     "//ios/chrome/browser/ui/collection_view/cells",
     "//ios/chrome/browser/ui/colors",
     "//ios/chrome/browser/ui/icons",
+    "//ios/chrome/browser/ui/settings",
+    "//ios/chrome/browser/ui/settings/cells",

[lpromero, 2017/03/13 16:42:36]

How come payments code needs this? I think we should extract what is needed and
move it to a shared location.

[Moe, 2017/03/16 01:35:32]

these are for the autofill_edit_accessory_view.h and autofill_edit_item.h.
I agree. I'll add a task to do that in a follow up CL. how does
ios/chrome/browser/ui/cells/ sound as the new home?

[lpromero, 2017/03/16 13:01:05]

Would they be generic enough to be in
ios/chrome/browser/ui/collection_view/cells? I think it would be OK.

     "//ios/third_party/material_components_ios",
     "//ios/third_party/material_roboto_font_loader_ios",
     "//ios/web",
     "//ui/base",
   ]
   libs = [ "UIKit.framework" ]
 }
 
 source_set("unit_tests") {
   configs += [ "//build/config/compiler:enable_arc" ]
@@ skipping 32 matching lines @@
     "//ios/chrome/browser/ui/collection_view/cells:test_support",
     "//ios/chrome/test:test_support",
     "//ios/testing:ocmock_support",
     "//ios/third_party/material_components_ios",
     "//ios/web",
     "//ios/web:test_support",
     "//testing/gtest",
     "//third_party/ocmock",
   ]
 }