🏠 Add pull-handle to bottom toolbar

chrome/android/java/res/layout/bottom_control_container.xml

Index: chrome/android/java/res/layout/bottom_control_container.xml
diff --git a/chrome/android/java/res/layout/bottom_control_container.xml b/chrome/android/java/res/layout/bottom_control_container.xml
index a6ca2886d28f915e9d9c9638e915f157255424d7..9f7b8a511121d70ca9c6d42a443ec930e99a2eb4 100644
--- a/chrome/android/java/res/layout/bottom_control_container.xml
+++ b/chrome/android/java/res/layout/bottom_control_container.xml
@@ -13,12 +13,13 @@
         android:id="@+id/control_container"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:minHeight="@dimen/control_container_height" >
+        android:minHeight="@dimen/bottom_control_container_height" >
+
         <view
             class="org.chromium.chrome.browser.toolbar.ToolbarControlContainer$ToolbarViewResourceFrameLayout"
             android:id="@+id/toolbar_container"
             android:layout_width="match_parent"
-            android:layout_height="wrap_content">
+            android:layout_height="wrap_content" >
             <ImageView
                 android:id="@+id/bottom_toolbar_shadow"
                 android:layout_width="match_parent"
@@ -30,16 +31,22 @@
             <ViewStub
                 android:id="@+id/toolbar_stub"
                 android:layout_width="match_parent"
-                android:layout_height="@dimen/toolbar_height_no_shadow"
+                android:layout_height="@dimen/bottom_control_container_height"
                 android:layout_marginTop="@dimen/toolbar_shadow_height" />

[Theresa, 2017/03/13 23:08:42]

What happens if we adjust this margin rather than programatically push down all
of the toolbar items?

[mdjones, 2017/03/13 23:43:39]

All the contents try to adjust to the new height. I would set the size of the
toolbar container to be smaller but then the background is too short.

[Theresa, 2017/03/14 00:01:45]

Okay -- so we may have to programatically adjust the margin on all of the
various toolbar's button? Maybe we can wrap the toolbar button and apply the
margin to one view/toolbar?

[mdjones, 2017/03/14 16:25:28]

I can, but I would need to make two copies of what is now
toolbar_phone_common.xml; the buttons/location bar/background are all part of
the same layout.

             <ViewStub
                 android:id="@+id/find_toolbar_stub"
                 android:inflatedId="@+id/find_toolbar"
                 android:layout_marginTop="@dimen/toolbar_shadow_height"
                 android:layout_width="match_parent"
-                android:layout_height="@dimen/toolbar_height_no_shadow"
-                android:layout="@layout/find_toolbar"
-                android:visibility="gone" />
+                android:layout_height="@dimen/bottom_control_container_height"
+                android:layout="@layout/find_toolbar" />
+            <ImageView
+                android:id="@+id/toolbar_handle"
+                android:layout_width="@dimen/toolbar_handle_width"
+                android:layout_height="@dimen/toolbar_handle_height"
+                android:layout_marginTop="@dimen/toolbar_handle_margin_top"
+                android:layout_gravity="center|top"
+                android:contentDescription="@null" />
         </view>
     </org.chromium.chrome.browser.toolbar.ToolbarControlContainer>