chrome/android/java/res/layout/bottom_control_container.xml - Issue 2744763005: 🏠 Add pull-handle to bottom toolbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/bottom_control_container.xml

Issue 2744763005: 🏠 Add pull-handle to bottom toolbar (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/layout/bottom_toolbar_phone.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/bottom_control_container.xml

diff --git a/chrome/android/java/res/layout/bottom_control_container.xml b/chrome/android/java/res/layout/bottom_control_container.xml

index a6ca2886d28f915e9d9c9638e915f157255424d7..9f7b8a511121d70ca9c6d42a443ec930e99a2eb4 100644

--- a/chrome/android/java/res/layout/bottom_control_container.xml

+++ b/chrome/android/java/res/layout/bottom_control_container.xml

@@ -13,12 +13,13 @@

android:id="@+id/control_container"

android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:minHeight="@dimen/control_container_height" >

+ android:minHeight="@dimen/bottom_control_container_height" >

<view

class="org.chromium.chrome.browser.toolbar.ToolbarControlContainer$ToolbarViewResourceFrameLayout"

android:id="@+id/toolbar_container"

android:layout_width="match_parent"

- android:layout_height="wrap_content">

+ android:layout_height="wrap_content" >

<ImageView

android:id="@+id/bottom_toolbar_shadow"

android:layout_width="match_parent"

@@ -30,16 +31,22 @@

<ViewStub

android:id="@+id/toolbar_stub"

android:layout_width="match_parent"

- android:layout_height="@dimen/toolbar_height_no_shadow"

+ android:layout_height="@dimen/bottom_control_container_height"

android:layout_marginTop="@dimen/toolbar_shadow_height" />

<ViewStub

android:id="@+id/find_toolbar_stub"

android:inflatedId="@+id/find_toolbar"

android:layout_marginTop="@dimen/toolbar_shadow_height"

android:layout_width="match_parent"

- android:layout_height="@dimen/toolbar_height_no_shadow"

- android:layout="@layout/find_toolbar"

- android:visibility="gone" />

+ android:layout_height="@dimen/bottom_control_container_height"

+ android:layout="@layout/find_toolbar" />

+ <ImageView

+ android:id="@+id/toolbar_handle"

+ android:layout_width="@dimen/toolbar_handle_width"

+ android:layout_height="@dimen/toolbar_handle_height"

+ android:layout_marginTop="@dimen/toolbar_handle_margin_top"

+ android:layout_gravity="center|top"

+ android:contentDescription="@null" />

</view>

</org.chromium.chrome.browser.toolbar.ToolbarControlContainer>