Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 274473004: Nitpicking fixes for Files.app code. (Closed)

Created:
6 years, 7 months ago by kinaba
Modified:
6 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Nitpicking fixes for Files.app code. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M chrome/browser/chromeos/file_manager/volume_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/audio_player/elements/audio_player.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/audio_player/elements/volume_controller.js View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/background/js/file_operation_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/drive_banners.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/image_editor/image_editor.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/media/audio_player.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/conflict_dialog.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/navigation_list.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/preview_panel.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/search_box.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/image_loader/cache.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/image_loader/image_loader.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/error_util.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
Mostly typo fixes.
6 years, 7 months ago (2014-05-09 07:24:34 UTC) #1
hirono
On 2014/05/09 07:24:34, kinaba wrote: > Mostly typo fixes. lgtm! Thank you!
6 years, 7 months ago (2014-05-09 07:34:05 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-09 07:34:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/274473004/1
6 years, 7 months ago (2014-05-09 07:37:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 09:31:52 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 07:50:48 UTC) #6
Message was sent while issue was closed. 
Change committed as 269555

Powered by Google App Engine
This is Rietveld 408576698