Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 274473003: Reland another small part of r267947. Second attempt. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, darin (slow to review)
Visibility:
Public.

Description

Reland another small part of r267947. Second attempt. This just contains only the download_to_file chuck from r267947 which is unlikely to break any layout tests, existing unit tests or chrome production code. Tests ran: both content_shell and content_unittests BUG=265753, 338338, 237249 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269432

Patch Set 1 #

Patch Set 2 : fix for heap-use-after-free cautch by linux asan #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -52 lines) Patch
M content/child/resource_dispatcher.h View 1 2 4 chunks +27 lines, -34 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 2 11 chunks +30 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
tfarina
ptal. fired some tsan, asan bots to make sure it doesn't happen again. sorry for ...
6 years, 7 months ago (2014-05-09 02:21:18 UTC) #1
tfarina
FYI, linux_asan trybot does not run content_unittests. Sigh :/ Hopefully, looks like mac_asan does.
6 years, 7 months ago (2014-05-09 03:31:45 UTC) #2
tfarina
I have filed crbug.com/371674 for the trybot difference.
6 years, 7 months ago (2014-05-09 03:34:14 UTC) #3
tfarina
content_unittests passed on mac_asan: http://build.chromium.org/p/tryserver.chromium/builders/mac_asan/builds/42500/steps/content_unittests
6 years, 7 months ago (2014-05-09 03:55:20 UTC) #4
jam
lgtm
6 years, 7 months ago (2014-05-09 17:18:41 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-09 17:29:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/274473003/20001
6 years, 7 months ago (2014-05-09 17:31:05 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 17:45:08 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 17:49:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66847) linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/15737)
6 years, 7 months ago (2014-05-09 17:49:26 UTC) #10
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-09 19:59:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/274473003/20001
6 years, 7 months ago (2014-05-09 20:04:11 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 20:41:03 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 20:49:08 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66896) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/15755)
6 years, 7 months ago (2014-05-09 20:49:08 UTC) #15
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-09 21:25:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/274473003/40001
6 years, 7 months ago (2014-05-09 21:30:18 UTC) #17
tfarina
6 years, 7 months ago (2014-05-09 22:18:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 manually as r269432 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698