Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: tools/perf/benchmarks/v8_browsing.py

Issue 2744723003: Adding owners to benchmark tests (Closed)
Patch Set: rebasing Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/v8.py ('k') | tools/perf/benchmarks/webrtc.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from benchmarks import v8_helper 7 from benchmarks import v8_helper
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import chrome_trace_config 10 from telemetry.timeline import chrome_trace_config
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 return possible_browser.platform.GetDeviceTypeName() != 'Desktop' 149 return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
150 150
151 151
152 class _V8MobileBrowsingBenchmark(_V8BrowsingBenchmark): 152 class _V8MobileBrowsingBenchmark(_V8BrowsingBenchmark):
153 153
154 @classmethod 154 @classmethod
155 def ShouldDisable(cls, possible_browser): 155 def ShouldDisable(cls, possible_browser):
156 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' 156 return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
157 157
158 158
159 @benchmark.Owner(emails=['ulan@chromium.org'])
159 class V8DesktopBrowsingBenchmark(_V8DesktopBrowsingBenchmark): 160 class V8DesktopBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
160 PLATFORM = 'desktop' 161 PLATFORM = 'desktop'
161 TEST_SUFFIX = '' 162 TEST_SUFFIX = ''
162 163
163 164
165 @benchmark.Owner(emails=['ulan@chromium.org'])
164 @benchmark.Disabled('reference') # http://crbug.com/628631 166 @benchmark.Disabled('reference') # http://crbug.com/628631
165 class V8MobileBrowsingBenchmark(_V8MobileBrowsingBenchmark): 167 class V8MobileBrowsingBenchmark(_V8MobileBrowsingBenchmark):
166 PLATFORM = 'mobile' 168 PLATFORM = 'mobile'
167 TEST_SUFFIX = '' 169 TEST_SUFFIX = ''
168 170
169 171
170 @benchmark.Disabled('reference') # http://crbug.com/700390 172 @benchmark.Disabled('reference') # http://crbug.com/700390
173 @benchmark.Owner(emails=['mvstaton@chromium.org'])
171 class V8DesktopTurboBrowsingBenchmark(_V8DesktopBrowsingBenchmark): 174 class V8DesktopTurboBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
172 PLATFORM = 'desktop' 175 PLATFORM = 'desktop'
173 TEST_SUFFIX = '_turbo' 176 TEST_SUFFIX = '_turbo'
174 177
175 def SetExtraBrowserOptions(self, options): 178 def SetExtraBrowserOptions(self, options):
176 super(V8DesktopTurboBrowsingBenchmark, self).SetExtraBrowserOptions( 179 super(V8DesktopTurboBrowsingBenchmark, self).SetExtraBrowserOptions(
177 options) 180 options)
178 v8_helper.EnableTurbo(options) 181 v8_helper.EnableTurbo(options)
179 182
180 183
181 @benchmark.Disabled('reference') # http://crbug.com/628631 184 @benchmark.Disabled('reference') # http://crbug.com/628631
185 @benchmark.Owner(emails=['mvstaton@chromium.org'])
182 class V8MobileTurboBrowsingBenchmark(_V8MobileBrowsingBenchmark): 186 class V8MobileTurboBrowsingBenchmark(_V8MobileBrowsingBenchmark):
183 PLATFORM = 'mobile' 187 PLATFORM = 'mobile'
184 TEST_SUFFIX = '_turbo' 188 TEST_SUFFIX = '_turbo'
185 189
186 def SetExtraBrowserOptions(self, options): 190 def SetExtraBrowserOptions(self, options):
187 super(V8MobileTurboBrowsingBenchmark, self).SetExtraBrowserOptions( 191 super(V8MobileTurboBrowsingBenchmark, self).SetExtraBrowserOptions(
188 options) 192 options)
189 193
190 194
195 @benchmark.Owner(emails=['mythria@chromium.org'])
191 class V8RuntimeStatsDesktopBrowsingBenchmark( 196 class V8RuntimeStatsDesktopBrowsingBenchmark(
192 _V8RuntimeStatsBrowsingBenchmark): 197 _V8RuntimeStatsBrowsingBenchmark):
193 PLATFORM = 'desktop' 198 PLATFORM = 'desktop'
194 TEST_SUFFIX = '' 199 TEST_SUFFIX = ''
195 200
196 @classmethod 201 @classmethod
197 def ShouldDisable(cls, possible_browser): 202 def ShouldDisable(cls, possible_browser):
198 return possible_browser.platform.GetDeviceTypeName() != 'Desktop' 203 return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
199 204
200 205
201 @benchmark.Disabled('reference') # http://crbug.com/700390 206 @benchmark.Disabled('reference') # http://crbug.com/700390
207 @benchmark.Owner(emails=['mythria@chromium.org'])
202 class V8RuntimeStatsDesktopTurboBrowsingBenchmark( 208 class V8RuntimeStatsDesktopTurboBrowsingBenchmark(
203 _V8RuntimeStatsBrowsingBenchmark): 209 _V8RuntimeStatsBrowsingBenchmark):
204 PLATFORM = 'desktop' 210 PLATFORM = 'desktop'
205 TEST_SUFFIX = '_turbo' 211 TEST_SUFFIX = '_turbo'
206 212
207 def SetExtraBrowserOptions(self, options): 213 def SetExtraBrowserOptions(self, options):
208 super(V8RuntimeStatsDesktopTurboBrowsingBenchmark, 214 super(V8RuntimeStatsDesktopTurboBrowsingBenchmark,
209 self).SetExtraBrowserOptions(options) 215 self).SetExtraBrowserOptions(options)
210 v8_helper.EnableTurbo(options) 216 v8_helper.EnableTurbo(options)
211 217
212 @classmethod 218 @classmethod
213 def ShouldDisable(cls, possible_browser): 219 def ShouldDisable(cls, possible_browser):
214 return possible_browser.platform.GetDeviceTypeName() != 'Desktop' 220 return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
215 221
216 222
217 @benchmark.Disabled('reference') # http://crbug.com/694658 223 @benchmark.Disabled('reference') # http://crbug.com/694658
224 @benchmark.Owner(emails=['mythria@chromium.org'])
218 class V8RuntimeStatsMobileBrowsingBenchmark( 225 class V8RuntimeStatsMobileBrowsingBenchmark(
219 _V8RuntimeStatsBrowsingBenchmark): 226 _V8RuntimeStatsBrowsingBenchmark):
220 PLATFORM = 'mobile' 227 PLATFORM = 'mobile'
221 TEST_SUFFIX = '' 228 TEST_SUFFIX = ''
222 229
223 @classmethod 230 @classmethod
224 def ShouldDisable(cls, possible_browser): 231 def ShouldDisable(cls, possible_browser):
225 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' 232 return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
226 233
227 234
228 @benchmark.Disabled('reference') # http://crbug.com/694658 235 @benchmark.Disabled('reference') # http://crbug.com/694658
236 @benchmark.Owner(emails=['mythria@chromium.org'])
229 class V8RuntimeStatsMobileTurboBrowsingBenchmark( 237 class V8RuntimeStatsMobileTurboBrowsingBenchmark(
230 _V8RuntimeStatsBrowsingBenchmark): 238 _V8RuntimeStatsBrowsingBenchmark):
231 PLATFORM = 'mobile' 239 PLATFORM = 'mobile'
232 TEST_SUFFIX = '_turbo' 240 TEST_SUFFIX = '_turbo'
233 241
234 def SetExtraBrowserOptions(self, options): 242 def SetExtraBrowserOptions(self, options):
235 super(V8RuntimeStatsMobileTurboBrowsingBenchmark, 243 super(V8RuntimeStatsMobileTurboBrowsingBenchmark,
236 self).SetExtraBrowserOptions(options) 244 self).SetExtraBrowserOptions(options)
237 v8_helper.EnableTurbo(options) 245 v8_helper.EnableTurbo(options)
238 246
239 @classmethod 247 @classmethod
240 def ShouldDisable(cls, possible_browser): 248 def ShouldDisable(cls, possible_browser):
241 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' 249 return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
242 250
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/v8.py ('k') | tools/perf/benchmarks/webrtc.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698