Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: tools/perf/benchmarks/thread_times.py

Issue 2744723003: Adding owners to benchmark tests (Closed)
Patch Set: rebasing Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/text_selection.py ('k') | tools/perf/benchmarks/tracing.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from benchmarks import silk_flags 7 from benchmarks import silk_flags
8 from measurements import thread_times 8 from measurements import thread_times
9 import page_sets 9 import page_sets
10 from telemetry import benchmark 10 from telemetry import benchmark
(...skipping 16 matching lines...) Expand all
27 return 'per_second' not in value.name 27 return 'per_second' not in value.name
28 28
29 def SetExtraBrowserOptions(self, options): 29 def SetExtraBrowserOptions(self, options):
30 silk_flags.CustomizeBrowserOptionsForThreadTimes(options) 30 silk_flags.CustomizeBrowserOptionsForThreadTimes(options)
31 31
32 def CreatePageTest(self, options): 32 def CreatePageTest(self, options):
33 return thread_times.ThreadTimes(options.report_silk_details) 33 return thread_times.ThreadTimes(options.report_silk_details)
34 34
35 35
36 @benchmark.Enabled('android') 36 @benchmark.Enabled('android')
37 @benchmark.Owner(emails=['vmiura@chromium.org'])
37 class ThreadTimesKeySilkCases(_ThreadTimes): 38 class ThreadTimesKeySilkCases(_ThreadTimes):
38 """Measures timeline metrics while performing smoothness action on key silk 39 """Measures timeline metrics while performing smoothness action on key silk
39 cases.""" 40 cases."""
40 page_set = page_sets.KeySilkCasesPageSet 41 page_set = page_sets.KeySilkCasesPageSet
41 42
42 @classmethod 43 @classmethod
43 def Name(cls): 44 def Name(cls):
44 return 'thread_times.key_silk_cases' 45 return 'thread_times.key_silk_cases'
45 46
46 47
(...skipping 15 matching lines...) Expand all
62 http://www.chromium.org/developers/design-documents/rendering-benchmarks""" 63 http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
63 page_set = page_sets.KeyMobileSitesSmoothPageSet 64 page_set = page_sets.KeyMobileSitesSmoothPageSet
64 options = {'story_tag_filter': 'fastpath'} 65 options = {'story_tag_filter': 'fastpath'}
65 66
66 @classmethod 67 @classmethod
67 def Name(cls): 68 def Name(cls):
68 return 'thread_times.key_mobile_sites_smooth' 69 return 'thread_times.key_mobile_sites_smooth'
69 70
70 71
71 @benchmark.Enabled('android') 72 @benchmark.Enabled('android')
73 @benchmark.Owner(emails=['vmiura@chromium.org'])
72 class ThreadTimesSimpleMobileSites(_ThreadTimes): 74 class ThreadTimesSimpleMobileSites(_ThreadTimes):
73 """Measures timeline metric using smoothness action on simple mobile sites 75 """Measures timeline metric using smoothness action on simple mobile sites
74 http://www.chromium.org/developers/design-documents/rendering-benchmarks""" 76 http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
75 page_set = page_sets.SimpleMobileSitesPageSet 77 page_set = page_sets.SimpleMobileSitesPageSet
76 78
77 @classmethod 79 @classmethod
78 def Name(cls): 80 def Name(cls):
79 return 'thread_times.simple_mobile_sites' 81 return 'thread_times.simple_mobile_sites'
80 82
81 83
84 @benchmark.Owner(emails=['vmiura@chromium.org'])
82 class ThreadTimesCompositorCases(_ThreadTimes): 85 class ThreadTimesCompositorCases(_ThreadTimes):
83 """Measures timeline metrics while performing smoothness action on 86 """Measures timeline metrics while performing smoothness action on
84 tough compositor cases, using software rasterization. 87 tough compositor cases, using software rasterization.
85 88
86 http://www.chromium.org/developers/design-documents/rendering-benchmarks""" 89 http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
87 page_set = page_sets.ToughCompositorCasesPageSet 90 page_set = page_sets.ToughCompositorCasesPageSet
88 91
89 def SetExtraBrowserOptions(self, options): 92 def SetExtraBrowserOptions(self, options):
90 super(ThreadTimesCompositorCases, self).SetExtraBrowserOptions(options) 93 super(ThreadTimesCompositorCases, self).SetExtraBrowserOptions(options)
91 silk_flags.CustomizeBrowserOptionsForSoftwareRasterization(options) 94 silk_flags.CustomizeBrowserOptionsForSoftwareRasterization(options)
92 95
93 @classmethod 96 @classmethod
94 def Name(cls): 97 def Name(cls):
95 return 'thread_times.tough_compositor_cases' 98 return 'thread_times.tough_compositor_cases'
96 99
97 100
98 @benchmark.Enabled('android') 101 @benchmark.Enabled('android')
102 @benchmark.Owner(emails=['ykyyip@chromium.org'])
99 class ThreadTimesPolymer(_ThreadTimes): 103 class ThreadTimesPolymer(_ThreadTimes):
100 """Measures timeline metrics while performing smoothness action on 104 """Measures timeline metrics while performing smoothness action on
101 Polymer cases.""" 105 Polymer cases."""
102 page_set = page_sets.PolymerPageSet 106 page_set = page_sets.PolymerPageSet
103 107
104 @classmethod 108 @classmethod
105 def Name(cls): 109 def Name(cls):
106 return 'thread_times.polymer' 110 return 'thread_times.polymer'
107 111
108 112
109 @benchmark.Enabled('android') 113 @benchmark.Enabled('android')
114 @benchmark.Owner(emails=['skyostil@chromium.org'])
110 class ThreadTimesKeyIdlePowerCases(_ThreadTimes): 115 class ThreadTimesKeyIdlePowerCases(_ThreadTimes):
111 """Measures timeline metrics for sites that should be idle in foreground 116 """Measures timeline metrics for sites that should be idle in foreground
112 and background scenarios. The metrics are per-second rather than per-frame.""" 117 and background scenarios. The metrics are per-second rather than per-frame."""
113 page_set = page_sets.KeyIdlePowerCasesPageSet 118 page_set = page_sets.KeyIdlePowerCasesPageSet
114 119
115 @classmethod 120 @classmethod
116 def Name(cls): 121 def Name(cls):
117 return 'thread_times.key_idle_power_cases' 122 return 'thread_times.key_idle_power_cases'
118 123
119 @classmethod 124 @classmethod
(...skipping 11 matching lines...) Expand all
131 @classmethod 136 @classmethod
132 def Name(cls): 137 def Name(cls):
133 return 'thread_times.key_noop_cases' 138 return 'thread_times.key_noop_cases'
134 139
135 @classmethod 140 @classmethod
136 def ValueCanBeAddedPredicate(cls, value, _): 141 def ValueCanBeAddedPredicate(cls, value, _):
137 # Only report per-second metrics. 142 # Only report per-second metrics.
138 return 'per_frame' not in value.name and 'mean_frame' not in value.name 143 return 'per_frame' not in value.name and 'mean_frame' not in value.name
139 144
140 145
146 @benchmark.Owner(emails=['tdresser@chromium.org'])
141 class ThreadTimesToughScrollingCases(_ThreadTimes): 147 class ThreadTimesToughScrollingCases(_ThreadTimes):
142 """Measure timeline metrics while performing smoothness action on tough 148 """Measure timeline metrics while performing smoothness action on tough
143 scrolling cases.""" 149 scrolling cases."""
144 page_set = page_sets.ToughScrollingCasesPageSet 150 page_set = page_sets.ToughScrollingCasesPageSet
145 151
146 @classmethod 152 @classmethod
147 def Name(cls): 153 def Name(cls):
148 return 'thread_times.tough_scrolling_cases' 154 return 'thread_times.tough_scrolling_cases'
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/text_selection.py ('k') | tools/perf/benchmarks/tracing.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698