Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: tools/perf/benchmarks/text_selection.py

Issue 2744723003: Adding owners to benchmark tests (Closed)
Patch Set: rebasing Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/system_health.py ('k') | tools/perf/benchmarks/thread_times.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from telemetry import benchmark 7 from telemetry import benchmark
8 from telemetry.timeline import chrome_trace_category_filter 8 from telemetry.timeline import chrome_trace_category_filter
9 from telemetry.web_perf import timeline_based_measurement 9 from telemetry.web_perf import timeline_based_measurement
10 10
(...skipping 20 matching lines...) Expand all
31 31
32 @classmethod 32 @classmethod
33 def ValueCanBeAddedPredicate(cls, value, is_first_result): 33 def ValueCanBeAddedPredicate(cls, value, is_first_result):
34 if 'text-selection' not in value.name: 34 if 'text-selection' not in value.name:
35 return False 35 return False
36 return value.values != None 36 return value.values != None
37 37
38 38
39 # See crbug.com/519044 39 # See crbug.com/519044
40 @benchmark.Disabled('all') 40 @benchmark.Disabled('all')
41 @benchmark.Owner(emails=['mfomitchev@chromium.org'])
41 class TextSelectionDirection(_TextSelection): 42 class TextSelectionDirection(_TextSelection):
42 """Measure text selection metrics while dragging a touch selection handle on a 43 """Measure text selection metrics while dragging a touch selection handle on a
43 subset of top ten mobile sites and using the 'direction' touch selection 44 subset of top ten mobile sites and using the 'direction' touch selection
44 strategy.""" 45 strategy."""
45 46
46 def SetExtraBrowserOptions(self, options): 47 def SetExtraBrowserOptions(self, options):
47 options.AppendExtraBrowserArgs(['--touch-selection-strategy=direction']) 48 options.AppendExtraBrowserArgs(['--touch-selection-strategy=direction'])
48 49
49 @classmethod 50 @classmethod
50 def Name(cls): 51 def Name(cls):
51 return 'text_selection.direction' 52 return 'text_selection.direction'
52 53
53 54
54 # See crbug.com/519044 55 # See crbug.com/519044
55 @benchmark.Disabled('all') 56 @benchmark.Disabled('all')
57 @benchmark.Owner(emails=['mfomitchev@chromium.org'])
56 class TextSelectionCharacter(_TextSelection): 58 class TextSelectionCharacter(_TextSelection):
57 """Measure text selection metrics while dragging a touch selection handle on a 59 """Measure text selection metrics while dragging a touch selection handle on a
58 subset of top ten mobile sites and using the 'character' touch selection 60 subset of top ten mobile sites and using the 'character' touch selection
59 strategy.""" 61 strategy."""
60 62
61 def SetExtraBrowserOptions(self, options): 63 def SetExtraBrowserOptions(self, options):
62 options.AppendExtraBrowserArgs(['--touch-selection-strategy=character']) 64 options.AppendExtraBrowserArgs(['--touch-selection-strategy=character'])
63 65
64 @classmethod 66 @classmethod
65 def Name(cls): 67 def Name(cls):
66 return 'text_selection.character' 68 return 'text_selection.character'
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/system_health.py ('k') | tools/perf/benchmarks/thread_times.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698