Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: tools/perf/benchmarks/skpicture_printer.py

Issue 2744723003: Adding owners to benchmark tests (Closed)
Patch Set: rebasing Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/service_worker.py ('k') | tools/perf/benchmarks/smoothness.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 import ct_benchmarks_util 7 import ct_benchmarks_util
8 import page_sets 8 import page_sets
9 from page_sets import repaint_helpers 9 from page_sets import repaint_helpers
10 from telemetry import benchmark 10 from telemetry import benchmark
11 from telemetry.core import discover 11 from telemetry.core import discover
12 from telemetry import story 12 from telemetry import story
13 13
14 from measurements import skpicture_printer 14 from measurements import skpicture_printer
15 15
16 16
17 def _MatchPageSetName(story_set_name, story_set_base_dir): 17 def _MatchPageSetName(story_set_name, story_set_base_dir):
18 story_sets = discover.DiscoverClasses(story_set_base_dir, story_set_base_dir, 18 story_sets = discover.DiscoverClasses(story_set_base_dir, story_set_base_dir,
19 story.StorySet).values() 19 story.StorySet).values()
20 for s in story_sets: 20 for s in story_sets:
21 if story_set_name == s.Name(): 21 if story_set_name == s.Name():
22 return s 22 return s
23 return None 23 return None
24 24
25 25
26 # Disabled because we do not plan on running this SKP benchmark on the perf 26 # Disabled because we do not plan on running this SKP benchmark on the perf
27 # waterfall any time soon. 27 # waterfall any time soon.
28 @benchmark.Disabled('all') 28 @benchmark.Disabled('all')
29 @benchmark.Owner(emails=['rmistry@chromium.org'])
29 class SkpicturePrinter(perf_benchmark.PerfBenchmark): 30 class SkpicturePrinter(perf_benchmark.PerfBenchmark):
30 31
31 @classmethod 32 @classmethod
32 def AddBenchmarkCommandLineArgs(cls, parser): 33 def AddBenchmarkCommandLineArgs(cls, parser):
33 parser.add_option('--page-set-name', action='store', type='string') 34 parser.add_option('--page-set-name', action='store', type='string')
34 parser.add_option('--page-set-base-dir', action='store', type='string') 35 parser.add_option('--page-set-base-dir', action='store', type='string')
35 parser.add_option('-s', '--skp-outdir', 36 parser.add_option('-s', '--skp-outdir',
36 help='Output directory for the SKP files') 37 help='Output directory for the SKP files')
37 38
38 @classmethod 39 @classmethod
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 def ProcessCommandLineArgs(cls, parser, args): 79 def ProcessCommandLineArgs(cls, parser, args):
79 ct_benchmarks_util.ValidateCommandLineArgs(parser, args) 80 ct_benchmarks_util.ValidateCommandLineArgs(parser, args)
80 81
81 def CreatePageTest(self, options): 82 def CreatePageTest(self, options):
82 return skpicture_printer.SkpicturePrinter(options.skp_outdir) 83 return skpicture_printer.SkpicturePrinter(options.skp_outdir)
83 84
84 def CreateStorySet(self, options): 85 def CreateStorySet(self, options):
85 return page_sets.CTPageSet( 86 return page_sets.CTPageSet(
86 options.urls_list, options.user_agent, options.archive_data_file, 87 options.urls_list, options.user_agent, options.archive_data_file,
87 run_page_interaction_callback=repaint_helpers.WaitThenRepaint) 88 run_page_interaction_callback=repaint_helpers.WaitThenRepaint)
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/service_worker.py ('k') | tools/perf/benchmarks/smoothness.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698