Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2160)

Unified Diff: gpu/config/gpu_test_config.h

Issue 2744663006: Fix skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve (Closed)
Patch Set: GPUInfo -> GPUTestBotConfig Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/config/gpu_test_config.h
diff --git a/gpu/config/gpu_test_config.h b/gpu/config/gpu_test_config.h
index 10e88c1f2f77683d0c1b50acf60c8dde89defecb..04ce2cbdc96aaeac49ac881c36e7e1cf2e01d078 100644
--- a/gpu/config/gpu_test_config.h
+++ b/gpu/config/gpu_test_config.h
@@ -65,6 +65,7 @@ class GPU_EXPORT GPUTestConfig {
void set_gpu_device_id(uint32_t id);
void set_build_type(int32_t build_type);
void set_api(int32_t api);
+ void set_machine_model_name(const std::string& machine_model_name);
virtual void AddGPUVendor(uint32_t gpu_vendor);
@@ -73,6 +74,7 @@ class GPU_EXPORT GPUTestConfig {
uint32_t gpu_device_id() const { return gpu_device_id_; }
int32_t build_type() const { return build_type_; }
int32_t api() const { return api_; }
+ std::string machine_model_name() const { return machine_model_name_; }
Zhenyao Mo 2017/03/11 18:29:16 nit: return const std::string&
// Check if the config is valid. For example, if gpu_device_id_ is set, but
// gpu_vendor_ is unknown, then it's invalid.
@@ -107,6 +109,9 @@ class GPU_EXPORT GPUTestConfig {
// Back-end rendering APIs.
int32_t api_;
+
+ // The machine model identifier. See GPUInfo for details.
+ std::string machine_model_name_;
};
class GPU_EXPORT GPUTestBotConfig : public GPUTestConfig {

Powered by Google App Engine
This is Rietveld 408576698