Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: tools/release/update_node.py

Issue 2744663005: Add script to update relevant changes to Node.js. (Closed)
Patch Set: address nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/release/test_update_node.py ('K') | « tools/release/testdata/v8/v8_new ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/release/update_node.py
diff --git a/tools/release/update_node.py b/tools/release/update_node.py
new file mode 100755
index 0000000000000000000000000000000000000000..e6c3e5f1b927416901c1e4bac7a276868637d066
--- /dev/null
+++ b/tools/release/update_node.py
@@ -0,0 +1,113 @@
+#!/usr/bin/env python
+# Copyright 2017 the V8 project authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import argparse
+import os
+import shutil
+import subprocess
+import sys
+
+TARGET_SUBDIR = os.path.join("deps", "v8")
+
+SUB_REPOSITORIES = [ ["testing", "gtest"],
+ ["third_party", "jinja2"],
Michael Achenbach 2017/03/16 11:29:19 Why isn't base/trace_event/common added here? It's
+ ["third_party", "markupsafe"] ]
+
+DELETE_FROM_GITIGNORE = [ "/base",
+ "/testing/gtest" ]
+
+# Node.js requires only a single header file from gtest to build V8.
+# Both jinja2 and markupsafe are required to generate part of the inspector.
+ADD_TO_GITIGNORE = [ "/testing/gtest/*",
+ "!/testing/gtest/include",
+ "/testing/gtest/include/*",
+ "!/testing/gtest/include/gtest",
+ "/testing/gtest/include/gtest/*",
+ "!/testing/gtest/include/gtest/gtest_prod.h",
+ "!/third_party/jinja2",
+ "!/third_party/markupsafe" ]
+
+def RunGclient(path):
+ assert os.path.isdir(path)
+ print ">> Running gclient sync"
+ subprocess.check_call("gclient sync --nohooks", cwd=path, shell=True)
+
+def UninitGit(path):
+ target = os.path.join(path, ".git")
+ if os.path.isdir(target):
+ print ">> Cleaning up %s" % path
+ shutil.rmtree(target)
+
+def UpdateTarget(repository, options):
+ source = os.path.join(options.v8_path, *repository)
+ target = os.path.join(options.node_path, TARGET_SUBDIR, *repository)
+ print ">> Updating target directory %s" % target
+ print ">> from active branch at %s" % source
+ if not os.path.exists(target):
+ os.makedirs(target)
+ # Remove possible remnants of previous incomplete runs.
+ UninitGit(target)
+
+ git_commands = [
+ "git init", # initialize target repo
+ "git remote add origin %s" % source, # point to the source repo
+ "git fetch origin HEAD", # sync to the current branch
+ "git reset --hard FETCH_HEAD", # reset to the current branch
+ "git clean -fd" # delete removed files
+ ]
+ try:
+ for command in git_commands:
+ subprocess.check_call(command, cwd=target, shell=True);
+ except:
+ raise
+ finally:
+ UninitGit(target)
+
+def UpdateGitIgnore(options):
+ file_name = os.path.join(options.node_path, TARGET_SUBDIR, ".gitignore")
+ assert os.path.isfile(file_name)
+ print ">> Updating .gitignore with lines"
+ with open(file_name) as gitignore:
+ content = gitignore.readlines()
+ content = [x.strip() for x in content]
+ for x in DELETE_FROM_GITIGNORE:
+ if x in content:
+ print "- %s" % x
+ content.remove(x)
+ for x in ADD_TO_GITIGNORE:
+ if x not in content:
+ print "+ %s" % x
+ content.append(x)
+ content.sort(key=lambda x: x[1:] if x.startswith("!") else x)
+ with open(file_name, "w") as gitignore:
+ for x in content:
+ gitignore.write("%s\n" % x)
+
+def ParseOptions(args):
+ parser = argparse.ArgumentParser(description="Update V8 in Node.js")
+ parser.add_argument("v8_path", help="Path to V8 checkout")
+ parser.add_argument("node_path", help="Path to Node.js checkout")
+ parser.add_argument("--gclient", dest="gclient",
+ action="store_true", help="Run gclient sync")
+ options = parser.parse_args(args)
+ assert os.path.isdir(options.v8_path)
+ options.v8_path = os.path.abspath(options.v8_path)
+ assert os.path.isdir(options.node_path)
+ options.node_path = os.path.abspath(options.node_path)
+ return options
+
+def Main(args):
+ options = ParseOptions(args)
+ if options.gclient:
+ RunGclient(options.v8_path)
+ # Update main V8 repository.
+ UpdateTarget([""], options)
+ # Patch .gitignore before updating sub-repositories.
+ UpdateGitIgnore(options)
+ for repo in SUB_REPOSITORIES:
+ UpdateTarget(repo, options)
+
+if __name__ == "__main__":
+ Main(sys.argv[1:])
« tools/release/test_update_node.py ('K') | « tools/release/testdata/v8/v8_new ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698