Add script to update relevant changes to Node.js.

tools/release/update_node.py

+#!/usr/bin/env python
+# Copyright 2017 the V8 project authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import argparse
+import os
+import shutil
+import subprocess
+
+TARGET_SUBDIR = os.path.join("deps", "v8")
+
+REPOSITORIES = [ [""],
+                 ["testing", "gtest"],
+                 ["third_party", "jinja2"],
+                 ["third_party", "markupsafe"] ]
+
+DELETE_FROM_GITIGNORE = [ "/base",
+                          "/testing/gtest" ]
+
+ADD_TO_GITIGNORE = [ "/testing/gtest/*",

[Michael Achenbach, 2017/03/13 17:13:20]

Maybe add a comment/documentation somewhere what to do when adding a new deps'ed
dependency. At least for gtest it's not really intuitive how we got here.

[Yang, 2017/03/14 07:49:00]

I added a comment.

+                     "!/testing/gtest/include",
+                     "/testing/gtest/include/*",
+                     "!/testing/gtest/include/gtest",
+                     "/testing/gtest/include/gtest/*",
+                     "!/testing/gtest/include/gtest/gtest_prod.h",
+                     "!/third_party/jinja2",
+                     "!/third_party/markupsafe" ]
+
+def RunGclient(path):
+  assert os.path.isdir(path)
+  print ">> Running gclient sync"
+  subprocess.call("gclient sync --nohooks", cwd=path, shell=True)
+
+def UninitGit(path):
+  target = os.path.join(path, ".git")
+  if os.path.isdir(target):
+    print ">> Cleaning up %s" % path
+    shutil.rmtree(target)
+
+def UpdateTarget(repository, options):
+  source = os.path.join(options.v8_path, *repository)
+  target = os.path.join(options.node_path, TARGET_SUBDIR, *repository)
+  print ">> Updating target directory %s" % target
+  print ">>     from active branch at %s" % source
+  # Remove possible remnants of previous incomplete runs.
+  UninitGit(target)
+
+  git_commands = [
+    "git init",                           # initialize target repo
+    "git remote add origin %s" % source,  # point to the source repo
+    "git fetch origin HEAD",              # sync to the current branch
+    "git reset --hard FETCH_HEAD",        # reset to the current branch
+    "git clean -fd"                       # delete removed files
+  ]
+  try:
+    for command in git_commands:
+      subprocess.call(command, cwd=target, shell=True)
+  except:
+    raise
+  finally:
+    UninitGit(target)
+  print
+
+def UpdateGitIgnore(options):
+  file_name = os.path.join(options.node_path, TARGET_SUBDIR, ".gitignore")
+  assert os.path.isfile(file_name)
+  print ">> Updating .gitignore with lines"
+  with open(file_name) as gitignore:
+    content = gitignore.readlines()
+  content = [x.strip() for x in content]
+  for x in DELETE_FROM_GITIGNORE:
+    if x in content:
+      print "- %s" % x
+      content.remove(x)
+  for x in ADD_TO_GITIGNORE:
+    if x not in content:
+      print "+ %s" % x
+      content.append(x)
+  content.sort(key=lambda x: x[1:] if x.startswith("!") else x)
+  with open(file_name, "w") as gitignore:
+    for x in content:
+      gitignore.write("%s\n" % x)
+
+def ParseOptions():
+  parser = argparse.ArgumentParser(description="Update V8 in Node.js")
+  parser.add_argument("v8_path", help="Path to V8 checkout")
+  parser.add_argument("node_path", help="Path to Node.js checkout")
+  parser.add_argument("--gclient", dest="gclient",
+                      action="store_true", help="Run gclient sync")
+  options = parser.parse_args()
+  assert os.path.isdir(options.v8_path)
+  options.v8_path = os.path.abspath(options.v8_path)
+  assert os.path.isdir(options.node_path)
+  options.node_path = os.path.abspath(options.node_path)
+  return options
+
+def Main():
+  options = ParseOptions()
+  if options.gclient:
+    RunGclient(options.v8_path)
+  for repo in REPOSITORIES:
+    UpdateTarget(repo, options)
+  UpdateGitIgnore(options)

[Michael Achenbach, 2017/03/13 10:33:23]

Possibility for confusion - not sure how it could be more robust.

1. node/deps/v8 is updated - this also copies v8's .gitignore and overwrites
node's.
2. git clean -fd is called to delete files (based on just updated .gitignore)

3. Now subrepos are updated, e.g. gtest

I think it works as it is now, but the order is important. If the git clean in
V8 is called in the end, it might purge more stuff.

[Yang, 2017/03/14 07:49:00]

I don't think .gitignore applies to 'git clean -fd' for-sub repositories, since
git clean is in the context of the temporary git repository created to sync.

But I changed the script nevertheless to be on the safe side.

+
+if __name__ == "__main__":
+  Main()