Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2744643003: DevTools: [Icons] normalize icon sizes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/consoleView.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 * @param {!SDK.ConsoleMessage} consoleMessage 312 * @param {!SDK.ConsoleMessage} consoleMessage
313 * @param {!SDK.Target} target 313 * @param {!SDK.Target} target
314 * @param {!Components.Linkifier} linkifier 314 * @param {!Components.Linkifier} linkifier
315 * @return {!Element} 315 * @return {!Element}
316 */ 316 */
317 _buildMessageWithStackTrace(consoleMessage, target, linkifier) { 317 _buildMessageWithStackTrace(consoleMessage, target, linkifier) {
318 var toggleElement = createElementWithClass('div', 'console-message-stack-tra ce-toggle'); 318 var toggleElement = createElementWithClass('div', 'console-message-stack-tra ce-toggle');
319 var contentElement = toggleElement.createChild('div', 'console-message-stack -trace-wrapper'); 319 var contentElement = toggleElement.createChild('div', 'console-message-stack -trace-wrapper');
320 320
321 var messageElement = this._buildMessage(consoleMessage); 321 var messageElement = this._buildMessage(consoleMessage);
322 var icon = UI.Icon.create('smallicon-triangle-right'); 322 var icon = UI.Icon.create('smallicon-triangle-right', 'console-message-expan d-icon');
323 var clickableElement = contentElement.createChild('div'); 323 var clickableElement = contentElement.createChild('div');
324 clickableElement.appendChild(icon); 324 clickableElement.appendChild(icon);
325 325
326 clickableElement.appendChild(messageElement); 326 clickableElement.appendChild(messageElement);
327 var stackTraceElement = contentElement.createChild('div'); 327 var stackTraceElement = contentElement.createChild('div');
328 var stackTracePreview = 328 var stackTracePreview =
329 Components.DOMPresentationUtils.buildStackTracePreviewContents(target, l inkifier, consoleMessage.stackTrace); 329 Components.DOMPresentationUtils.buildStackTracePreviewContents(target, l inkifier, consoleMessage.stackTrace);
330 stackTraceElement.appendChild(stackTracePreview); 330 stackTraceElement.appendChild(stackTracePreview);
331 stackTraceElement.classList.add('hidden'); 331 stackTraceElement.classList.add('hidden');
332 332
(...skipping 914 matching lines...) Expand 10 before | Expand all | Expand 10 after
1247 toMessageElement() { 1247 toMessageElement() {
1248 if (!this._element) { 1248 if (!this._element) {
1249 super.toMessageElement(); 1249 super.toMessageElement();
1250 this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon'); 1250 this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon');
1251 this._contentElement.insertBefore(this._expandGroupIcon, this._contentElem ent.firstChild); 1251 this._contentElement.insertBefore(this._expandGroupIcon, this._contentElem ent.firstChild);
1252 this.setCollapsed(this._collapsed); 1252 this.setCollapsed(this._collapsed);
1253 } 1253 }
1254 return this._element; 1254 return this._element;
1255 } 1255 }
1256 }; 1256 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/consoleView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698