Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 274463004: Revert of extract some common code from PictureRenderer (Closed)

Created:
6 years, 7 months ago by djsollen
Modified:
6 years, 7 months ago
Reviewers:
epoger, borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of extract some common code from PictureRenderer (https://codereview.chromium.org/273703006/) Reason for revert: breaking the android debug builds. It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue. Original issue's description: > extract some common code from PictureRenderer > > Committed: http://code.google.com/p/skia/source/detail?r=14638 TBR=borenet@google.com,epoger@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -251 lines) Patch
M gm/gm_expectations.h View 2 chunks +41 lines, -2 lines 0 comments Download
M gm/gm_expectations.cpp View 3 chunks +19 lines, -5 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tools.gyp View 3 chunks +1 line, -4 lines 0 comments Download
M gyp/utils.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D src/utils/SkDataUtils.h View 1 chunk +0 lines, -63 lines 0 comments Download
D src/utils/SkDataUtils.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M tools/PictureRenderer.h View 3 chunks +39 lines, -2 lines 0 comments Download
M tools/PictureRenderer.cpp View 2 chunks +63 lines, -4 lines 0 comments Download
D tools/image_expectations.h View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/image_expectations.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
djsollen
Created Revert of extract some common code from PictureRenderer
6 years, 7 months ago (2014-05-08 16:22:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/274463004/1
6 years, 7 months ago (2014-05-08 16:23:42 UTC) #2
commit-bot: I haz the power
Change committed as 14649
6 years, 7 months ago (2014-05-08 16:24:01 UTC) #3
epoger
6 years, 7 months ago (2014-05-08 19:00:54 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698