src/apinatives.js - Issue 274463003: Directly create API functions with readonly prototypes rather than converting. Remove FunctionSetRe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/apinatives.js

Issue 274463003: Directly create API functions with readonly prototypes rather than converting. Remove FunctionSetRe… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/apinatives.js

diff --git a/src/apinatives.js b/src/apinatives.js

index 0579caf544b9065f061aabb2d01e4c9b4dbb8b77..0b45b3f1a0a50028e880edf2e462ea540bd3d309 100644

--- a/src/apinatives.js

+++ b/src/apinatives.js

@@ -49,9 +49,8 @@ function InstantiateFunction(data, name) {

if (!isFunctionCached) {

try {

var flags = %GetTemplateField(data, kApiFlagOffset);

- var has_proto = !(flags & (1 << kRemovePrototypeBit));

var prototype;

- if (has_proto) {

+ if (!(flags & (1 << kRemovePrototypeBit))) {

var template = %GetTemplateField(data, kApiPrototypeTemplateOffset);

prototype = typeof template === 'undefined'

? {} : Instantiate(template);

@@ -68,9 +67,6 @@ function InstantiateFunction(data, name) {

if (name) %FunctionSetName(fun, name);

var doNotCache = flags & (1 << kDoNotCacheBit);

if (!doNotCache) cache[serialNumber] = fun;

- if (has_proto && flags & (1 << kReadOnlyPrototypeBit)) {

- %FunctionSetReadOnlyPrototype(fun);

- }

ConfigureTemplateInstance(fun, data);

if (doNotCache) return fun;

} catch (e) {

« no previous file with comments | « include/v8.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »