Issue 274463003: Directly create API functions with readonly prototypes rather than converting. Remove FunctionSetRe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274463003: Directly create API functions with readonly prototypes rather than converting. Remove FunctionSetRe… (Closed)

Created:
6 years, 7 months ago by Toon Verwaest

Modified:
6 years, 7 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Directly create API functions with readonly prototypes rather than converting. Remove FunctionSetReadOnlyPrototype. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21243

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -70 lines)			Patch
M	include/v8.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/apinatives.js	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	src/bootstrapper.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/contexts.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/factory.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/factory.cc	View	1 2 3	4 chunks	+15 lines, -7 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+0 lines, -43 lines	0 comments	Download
D	test/mjsunit/runtime-gen/functionsetreadonlyprototype.js	View	1 2 3 4	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Igor Sheludko

lgtm, given that you are going to land that after https://codereview.chromium.org/268363011/ "Array Iterator next should ...

6 years, 7 months ago (2014-05-08 13:44:54 UTC) #2

Toon Verwaest

6 years, 7 months ago (2014-05-09 17:59:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r21243 (presubmit successful).