Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: extensions/common/extensions_client.h

Issue 27446002: Move permission warning message handling from PermissionSet to PermissionMessageProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/permissions/permissions_data.cc ('k') | extensions/common/extensions_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extensions_client.h
diff --git a/extensions/common/extensions_client.h b/extensions/common/extensions_client.h
index eb3ebfee3f8a15589b0ac0cfae15e9bbe9bf8c98..ed06d322878aa54daa17303912552b726860048b 100644
--- a/extensions/common/extensions_client.h
+++ b/extensions/common/extensions_client.h
@@ -12,6 +12,7 @@ namespace extensions {
class FeatureProvider;
class PermissionMessage;
+class PermissionMessageProvider;
class PermissionsProvider;
class URLPatternSet;
@@ -19,16 +20,23 @@ class URLPatternSet;
// process. This should be implemented by the client of the extensions system.
class ExtensionsClient {
public:
+ // Initializes global state. Not done in the constructor because unit tests
+ // can create additional ExtensionsClients because the utility thread runs
+ // in-process.
+ virtual void Initialize() = 0;
+
// Returns a PermissionsProvider to initialize the permissions system.
virtual const PermissionsProvider& GetPermissionsProvider() const = 0;
+ // Returns the global PermissionMessageProvider to use to provide permission
+ // warning strings.
+ virtual const PermissionMessageProvider& GetPermissionMessageProvider()
+ const = 0;
+
// Gets a feature provider for a specific feature type.
virtual FeatureProvider* GetFeatureProviderByName(const std::string& name)
const = 0;
- // Called at startup. Registers the handlers for parsing manifests.
- virtual void RegisterManifestHandlers() const = 0;
-
// Takes the list of all hosts and filters out those with special
// permission strings. Adds the regular hosts to |new_hosts|,
// and adds the special permission messages to |messages|.
« no previous file with comments | « chrome/common/extensions/permissions/permissions_data.cc ('k') | extensions/common/extensions_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698