Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3473)

Unified Diff: chrome/common/extensions/chrome_extensions_client.cc

Issue 27446002: Move permission warning message handling from PermissionSet to PermissionMessageProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/chrome_extensions_client.cc
diff --git a/chrome/common/extensions/chrome_extensions_client.cc b/chrome/common/extensions/chrome_extensions_client.cc
index fbebb8c324a894ac3271b7cdd2cb31582ae32c0d..29dd4dbfaf7285c170785e2e0a569ce4cc2bbb8c 100644
--- a/chrome/common/extensions/chrome_extensions_client.cc
+++ b/chrome/common/extensions/chrome_extensions_client.cc
@@ -6,6 +6,8 @@
#include "chrome/common/extensions/chrome_manifest_handlers.h"
#include "chrome/common/extensions/features/base_feature_provider.h"
+#include "chrome/common/extensions/permissions/app_permission_message_provider.h"
+#include "chrome/common/extensions/permissions/extension_permission_message_provider.h"
#include "chrome/common/url_constants.h"
#include "content/public/common/url_constants.h"
#include "extensions/common/permissions/permission_message.h"
@@ -26,6 +28,22 @@ ChromeExtensionsClient::ChromeExtensionsClient()
ChromeExtensionsClient::~ChromeExtensionsClient() {
}
+void ChromeExtensionsClient::Initialize() {
+ RegisterChromeManifestHandlers();
+
+ ExtensionPermissionMessageProvider* extension_permission_message_provider =
+ new ExtensionPermissionMessageProvider;
+ AppPermissionMessageProvider* app_permission_message_provider =
+ new AppPermissionMessageProvider;
+ std::vector<std::pair<Manifest::Type, PermissionMessageProvider*> >
+ custom_providers;
+ custom_providers.push_back(std::make_pair(
+ Manifest::TYPE_PLATFORM_APP,
+ app_permission_message_provider));
+ PermissionMessageProvider::SetProviders(extension_permission_message_provider,
+ custom_providers);
+}
+
const PermissionsProvider&
ChromeExtensionsClient::GetPermissionsProvider() const {
return chrome_api_permissions_;
@@ -36,10 +54,6 @@ FeatureProvider* ChromeExtensionsClient::GetFeatureProviderByName(
return BaseFeatureProvider::GetByName(name);
}
-void ChromeExtensionsClient::RegisterManifestHandlers() const {
- RegisterChromeManifestHandlers();
-}
-
void ChromeExtensionsClient::FilterHostPermissions(
const URLPatternSet& hosts,
URLPatternSet* new_hosts,

Powered by Google App Engine
This is Rietveld 408576698